linux-kernel - Re: [PATCH net] net: hns3: fix a not link up issue when fibre port supports autoneg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200305.120539.348892699293645794.davem@davemloft.net>
Date:   Thu, 05 Mar 2020 12:05:39 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     tanhuazhong@...wei.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        salil.mehta@...wei.com, yisen.zhuang@...wei.com,
        linuxarm@...wei.com, kuba@...nel.org, shenjian15@...wei.com
Subject: Re: [PATCH net] net: hns3: fix a not link up issue when fibre port
 supports autoneg

From: Huazhong Tan <tanhuazhong@...wei.com>
Date: Thu, 5 Mar 2020 09:47:53 +0800

> From: Jian Shen <shenjian15@...wei.com>
> 
> When fibre port supports auto-negotiation, the IMP(Intelligent
> Management Process) processes the speed of auto-negotiation
> and the  user's speed separately.
> For below case, the port will get a not link up problem.
> step 1: disables auto-negotiation and sets speed to A, then
> the driver's MAC speed will be updated to A.
> step 2: enables auto-negotiation and MAC gets negotiated
> speed B, then the driver's MAC speed will be updated to B
> through querying in periodical task.
> step 3: MAC gets new negotiated speed A.
> step 4: disables auto-negotiation and sets speed to B before
> periodical task query new MAC speed A, the driver will  ignore
> the speed configuration.
> 
> This patch fixes it by skipping speed and duplex checking when
> fibre port supports auto-negotiation.
> 
> Fixes: 22f48e24a23d ("net: hns3: add autoneg and change speed support for fibre port")
> Signed-off-by: Jian Shen <shenjian15@...wei.com>
> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>

Applied and queued up for -stable, thanks.