lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 5 Mar 2020 13:16:29 -0800 From: Daniel Xu <dxu@...uu.xyz> To: cgroups@...r.kernel.org, tj@...nel.org, lizefan@...wei.com, hannes@...xchg.org Cc: Daniel Xu <dxu@...uu.xyz>, shakeelb@...gle.com, linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org, kernel-team@...com Subject: [PATCH v2 1/4] kernfs: kvmalloc xattr value instead of kmalloc It's not really necessary to have contiguous physical memory for xattr values. We no longer need to worry about higher order allocations failing with kvmalloc, especially because the xattr size limit is at 64K. Signed-off-by: Daniel Xu <dxu@...uu.xyz> --- fs/xattr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/xattr.c b/fs/xattr.c index 90dd78f0eb27..0d3c9b4d1914 100644 --- a/fs/xattr.c +++ b/fs/xattr.c @@ -817,7 +817,7 @@ struct simple_xattr *simple_xattr_alloc(const void *value, size_t size) if (len < sizeof(*new_xattr)) return NULL; - new_xattr = kmalloc(len, GFP_KERNEL); + new_xattr = kvmalloc(len, GFP_KERNEL); if (!new_xattr) return NULL; @@ -882,7 +882,7 @@ int simple_xattr_set(struct simple_xattrs *xattrs, const char *name, new_xattr->name = kstrdup(name, GFP_KERNEL); if (!new_xattr->name) { - kfree(new_xattr); + kvfree(new_xattr); return -ENOMEM; } } @@ -912,7 +912,7 @@ int simple_xattr_set(struct simple_xattrs *xattrs, const char *name, spin_unlock(&xattrs->lock); if (xattr) { kfree(xattr->name); - kfree(xattr); + kvfree(xattr); } return err; -- 2.21.1
Powered by blists - more mailing lists