linux-kernel - Re: [PATCH 1/2] bootconfig: Support O=<builddir> option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Mar 2020 20:52:54 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Masami Hiramatsu <mhiramat@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Borislav Petkov <bp@...en8.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 1/2] bootconfig: Support O=<builddir> option

On 3/4/20 7:17 PM, Steven Rostedt wrote:
> On Wed, 4 Mar 2020 15:04:43 -0800
> Randy Dunlap <rdunlap@...radead.org> wrote:
> 
>> On 3/3/20 3:24 AM, Masami Hiramatsu wrote:
>>> Support O=<builddir> option to build bootconfig tool in
>>> the other directory. As same as other tools, if you specify
>>> O=<builddir>, bootconfig command is build under <builddir>.  
>>
>> Hm.  If I use
>> $ make O=~/tmp -C tools/bootconfig
>>
>> that works: it builds bootconfig in ~/tmp.
>>
>> OTOH, if I sit at the top of the kernel source tree
>> and I enter
>> $ mkdir builddir
>> $ make O=builddir -C tools/bootconfig
>>
>> I get this:
>> make: Entering directory '/home/rdunlap/lnx/next/linux-next-20200304/tools/bootconfig'
>> ../scripts/Makefile.include:4: *** O=builddir does not exist.  Stop.
>> make: Leaving directory '/home/rdunlap/lnx/next/linux-next-20200304/tools/bootconfig'
>>
>> so it looks like tools/scripts/Makefile.include doesn't handle this case correctly
>> (which is how I do all of my builds).
>>
> 
> Do you build perf that way?

No.  It should also be fixed.

> $ mkdir buildir
> $ make O=buildir -C tools/perf/
> make: Entering directory '/work/git/linux-test.git/tools/perf'
>   BUILD:   Doing 'make -j24' parallel build
> ../scripts/Makefile.include:4: *** O=/work/git/linux-test.git/tools/perf/buildir does not exist.  Stop.
> make: *** [Makefile:70: all] Error 2
> make: Leaving directory '/work/git/linux-test.git/tools/perf'
> 
> -- Steve

Thanks.
-- 
~Randy