linux-kernel - Re: [PATCH 1/1] arm64: dts: qcom: sc7180: Added critical trip point Thermal-zones node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Mar 2020 21:19:27 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Rajeshwari <rkambl@...eaurora.org>
Cc:     Andy Gross <agross@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, sanm@...eaurora.org,
        sivaa@...eaurora.org
Subject: Re: [PATCH 1/1] arm64: dts: qcom: sc7180: Added critical trip point
 Thermal-zones node

On Wed 04 Mar 04:23 PST 2020, Rajeshwari wrote:

> To enable kernel critical shutdown feature added critical trip point to

s/added/add/
s/point/points/

> all non CPU sensors to perform shutdown in orderly manner.
> 
> Signed-off-by: Rajeshwari <rkambl@...eaurora.org>
> ---

No need to provide a cover-letter for a single patch.

>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 78 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 78 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index b8a72cf..7e5f14f 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1956,6 +1956,12 @@
>  					hysteresis = <2000>;
>  					type = "hot";
>  				};
> +
> +				aoss0_crit: aoss0_crit {
> +                                        temperature = <110000>;
> +                                        hysteresis = <2000>;
> +                                        type = "critical";
> +                                };

The indentation of all but the initial line is off. Same with below
hunks as well. Please correct this.

Regards,
Bjorn