linux-kernel - Re: [PATCH v2]tty:serial:mvebu-uart:fix a wrong return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <369c9e9a-9560-a465-31c8-1b79950b4875@suse.com>
Date:   Thu, 5 Mar 2020 07:09:15 +0100
From:   Jiri Slaby <jslaby@...e.com>
To:     tangbin <tangbin@...s.chinamobile.com>
Cc:     gregkh@...uxfoundation.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2]tty:serial:mvebu-uart:fix a wrong return

On 05. 03. 20, 2:38, tangbin wrote:
> in this place, the function should return a
> negative value and the PTR_ERR already returns
> a negative,so return -PTR_ERR() is wrong.
> 
> Signed-off-by: tangbin <tangbin@...s.chinamobile.com>

Acked-by: Jiri Slaby <jslaby@...e.cz>

> ---
>  drivers/tty/serial/mvebu-uart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c
> index c12a12556..4e9a59071 100644
> --- a/drivers/tty/serial/mvebu-uart.c
> +++ b/drivers/tty/serial/mvebu-uart.c
> @@ -851,7 +851,7 @@ static int mvebu_uart_probe(struct platform_device *pdev)
>  
>  	port->membase = devm_ioremap_resource(&pdev->dev, reg);
>  	if (IS_ERR(port->membase))
> -		return -PTR_ERR(port->membase);
> +		return PTR_ERR(port->membase);
>  
>  	mvuart = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_uart),
>  			      GFP_KERNEL);
> 

thanks,
-- 
js
suse labs