linux-kernel - Re: [RFC][PATCH] soc: qcom: rpmpd: Allow RPMPD driver to be loaded as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bfea3aec-3a0b-9374-eec2-0a435cf68e04@codeaurora.org>
Date:   Thu, 5 Mar 2020 12:26:17 +0530
From:   Rajendra Nayak <rnayak@...eaurora.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        John Stultz <john.stultz@...aro.org>
Cc:     lkml <linux-kernel@...r.kernel.org>, Todd Kjos <tkjos@...gle.com>,
        Saravana Kannan <saravanak@...gle.com>,
        Andy Gross <agross@...nel.org>, linux-arm-msm@...r.kernel.org
Subject: Re: [RFC][PATCH] soc: qcom: rpmpd: Allow RPMPD driver to be loaded as
 a module


>> -core_initcall(rpmpd_init);
>> +module_init(rpmpd_init);
> 
> Can't you keep this as core_initcall(), for the times when its builtin?
> 
> Additionally I believe you should add a call to unregister the driver,

and implement a .remove?

> and drop the suppress_bind_attrs.
> 
>> +MODULE_LICENSE("GPL");
> 
> "GPL v2" per the SPDX?
> 
> Regards,
> Bjorn
> 
>> -- 
>> 2.17.1
>>

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation