linux-kernel - Re: [PATCH] char: group some /dev configs together and un-split tty configs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Mar 2020 08:50:53 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] char: group some /dev configs together and un-split tty configs

On Thu, Mar 5, 2020 at 7:45 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> From: Randy Dunlap <rdunlap@...radead.org>
>
> Group /dev/{mem,kmem,nvram,raw,port} driver configs together.
> This also means that tty configs are now grouped together instead
> of being split up.
>
> This just moves Kconfig lines around. There are no other changes.
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/char/Kconfig |  100 ++++++++++++++++++++---------------------
>  1 file changed, 50 insertions(+), 50 deletions(-)
>
> --- linux-next-20200304.orig/drivers/char/Kconfig
> +++ linux-next-20200304/drivers/char/Kconfig
> @@ -7,25 +7,6 @@ menu "Character devices"
>
>  source "drivers/tty/Kconfig"
>
> -config DEVMEM
> -       bool "/dev/mem virtual device support"
> -       default y
> -       help
> -         Say Y here if you want to support the /dev/mem device.
> -         The /dev/mem device is used to access areas of physical
> -         memory.
> -         When in doubt, say "Y".
> -
> -config DEVKMEM
> -       bool "/dev/kmem virtual device support"
> -       # On arm64, VMALLOC_START < PAGE_OFFSET, which confuses kmem read/write
> -       depends on !ARM64
> -       help
> -         Say Y here if you want to support the /dev/kmem device. The
> -         /dev/kmem device is rarely used, but can be used for certain
> -         kind of kernel debugging operations.
> -         When in doubt, say "N".
> -
>  source "drivers/tty/serial/Kconfig"
>  source "drivers/tty/serdev/Kconfig"

Good idea!

Looking at the result though, how about including drivers/tty/*/Kconfig
from drivers/tty/Kconfig after this? From the user point of view, it's
the same, but it seems to be grouped more logically then.

CONFIG_SYNCLINK_CS (in drivers/char/pcmcia/Kconfig) is also a
tty option that should probably get moved, but I guess that's an unrelated
change, and it would make sense to move the driver along with the
option.

      Arnd