linux-kernel - RE: [PATCH] mmc: mmc: Fix the timing for clock changing in mmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR11MB269638142E2BF2C6E108B40A9CE20@BYAPR11MB2696.namprd11.prod.outlook.com>
Date:   Thu, 5 Mar 2020 08:57:44 +0000
From:   "Seo, Kyungmin" <kyungmin.seo@...el.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
CC:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] mmc: mmc: Fix the timing for clock changing in mmc

The mmc_hs400_to_hs200 function is called only in HS400 mode.
I saw the clock change from 200MHz to 52MHz via oscilloscope on real platform.

I think CMD6 is sent in HS400 mode with 200MHz clock, but it's not.
First CMD6 in mmc_hs400_to_hs200 function is sent with 52MHz clock.

Thanks
KM

-----Original Message-----
From: Ulf Hansson <ulf.hansson@...aro.org> 
Sent: Wednesday, March 4, 2020 8:09 PM
To: Seo, Kyungmin <kyungmin.seo@...el.com>
Cc: linux-mmc@...r.kernel.org; Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: mmc: Fix the timing for clock changing in mmc

On Wed, 12 Feb 2020 at 03:40, Kyungmin Seo <kyungmin.seo@...el.com> wrote:
>
> The clock has to be changed after sending CMD6 for HS mode selection 
> in
> mmc_hs400_to_hs200() function.
>
> The JEDEC 5.0 and 5.1 said that "High-speed" mode selection has to 
> enable the the high speed mode timing in the Device, before chaning 
> the clock frequency to a frequency between 26MHz and 52MHz.

I think that is based upon the assumption that you are using a lower frequency to start with.

For example, assume that you are running with 400KHz during card initialization, then you want to send the CMD6 to switch to HS mode and that should be done, before updating the clock rate.

mmc_hs400_to_hs200() goes the opposite direction, so I think the current code looks correct to me.

Kind regards
Uffe

>
> Signed-off-by: Kyungmin Seo <kyungmin.seo@...el.com>
> ---
>  drivers/mmc/core/mmc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index 
> 3486bc7fbb64..98640b51c73e 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1196,10 +1196,6 @@ int mmc_hs400_to_hs200(struct mmc_card *card)
>         int err;
>         u8 val;
>
> -       /* Reduce frequency to HS */
> -       max_dtr = card->ext_csd.hs_max_dtr;
> -       mmc_set_clock(host, max_dtr);
> -
>         /* Switch HS400 to HS DDR */
>         val = EXT_CSD_TIMING_HS;
>         err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, 
> EXT_CSD_HS_TIMING, @@ -1210,6 +1206,10 @@ int 
> mmc_hs400_to_hs200(struct mmc_card *card)
>
>         mmc_set_timing(host, MMC_TIMING_MMC_DDR52);
>
> +       /* Reduce frequency to HS */
> +       max_dtr = card->ext_csd.hs_max_dtr;
> +       mmc_set_clock(host, max_dtr);
> +
>         err = mmc_switch_status(card);
>         if (err)
>                 goto out_err;
> --
> 2.17.1
>