[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200305180402.cf9aa40f57880616d8c8d811@kernel.org>
Date: Thu, 5 Mar 2020 18:04:02 +0900
From: Masami Hiramatsu <mhiramat@...nel.org>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc: Adrian Hunter <adrian.hunter@...el.com>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Steven Rostedt <rostedt@...dmis.org>,
Borislav Petkov <bp@...en8.de>,
"H . Peter Anvin" <hpa@...or.com>, X86 ML <x86@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Mathieu Poirier <mathieu.poirier@...aro.org>,
Leo Yan <leo.yan@...aro.org>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Jiri Olsa <jolsa@...hat.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V4 03/13] kprobes: Add symbols for kprobe insn pages
On Wed, 4 Mar 2020 22:10:10 -0800
Alexei Starovoitov <alexei.starovoitov@...il.com> wrote:
> On Wed, Mar 4, 2020 at 10:01 PM Masami Hiramatsu <mhiramat@...nel.org> wrote:
> > >
> > > # perf probe __schedule
> > > Added new event:
> > > probe:__schedule (on __schedule)
> > > # cat /proc/kallsyms | grep '\[__builtin__kprobes\]'
> > > ffffffffc00d4000 t kprobe_insn_page [__builtin__kprobes]
> > > ffffffffc00d6000 t kprobe_optinsn_page [__builtin__kprobes]
> > >
> > > Note: This patch adds "__builtin__kprobes" as a module name in
> > > /proc/kallsyms for symbols for pages allocated for kprobes' purposes, even
> > > though "__builtin__kprobes" is not a module.
> >
> > Looks good to me.
> >
> > Acked-by: Masami Hiramatsu <mhiramat@...nel.org>
> >
> > BTW, would you also make a patch to change [bpf] to [__builtin__bpf]?
>
> Please do not.
> There is nothing 'builtin' about bpf.
Hmm, so, would we reject bpf.ko to be loaded ?
Thank you,
--
Masami Hiramatsu <mhiramat@...nel.org>
Powered by blists - more mailing lists