linux-kernel - Re: [RFC PATCH] leds: add sgm3140 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f61133d9-be0f-366a-7b77-1f366d2cd8d6@ti.com>
Date:   Thu, 5 Mar 2020 06:54:10 -0600
From:   Dan Murphy <dmurphy@...com>
To:     Luca Weiss <luca@...tu.xyz>, <linux-leds@...r.kernel.org>
CC:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] leds: add sgm3140 driver

Luca

On 3/5/20 5:01 AM, Luca Weiss wrote:
> On Donnerstag, 27. Februar 2020 20:50:40 CET Dan Murphy wrote:
>> Luca
>>
>> On 2/27/20 12:50 PM, Luca Weiss wrote:
>>> Add a driver for the SGMICRO SGM3140 Buck/Boost Charge Pump LED driver.
>>>
>>> This device is controller by two GPIO lines, one for enabling the LED
>>> and the second one for switching between torch and flash mode.
>>>
>>> The device will automatically switch to torch mode after being in flash
>>> mode for about 250-300ms, so after that time the driver will turn the
>>> LED off again automatically.
>>>
>>> Signed-off-by: Luca Weiss <luca@...tu.xyz>
>>> ---
>> You seem to be missing the devictree bindings doc for the GPIOs.
> As written in the initial email:
>
>> I will also write dt bindings for the driver once I have "strobe"
>> working.

NACK.

We review bindings as part of the code.  And we want to understand what 
bindings the code will be using

You will get better guidance if the patch set contains the documentation 
so we can understand what is being proposed.

Dan