linux-kernel - Re: [PATCH v1 1/1] sched/fair: do not preempt current task if it is going to call schedule()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202003052114.22Uw6Ht0%lkp@intel.com>
Date:   Thu, 5 Mar 2020 21:33:10 +0800
From:   kbuild test robot <lkp@...el.com>
To:     cl@...k-chips.com
Cc:     kbuild-all@...ts.01.org, heiko@...ech.de, mingo@...hat.com,
        peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        akpm@...ux-foundation.org, tglx@...utronix.de, mpe@...erman.id.au,
        surenb@...gle.com, ben.dooks@...ethink.co.uk,
        anshuman.khandual@....com, catalin.marinas@....com,
        will@...nel.org, keescook@...omium.org, luto@...capital.net,
        wad@...omium.org, mark.rutland@....com, geert+renesas@...der.be,
        george_davis@...tor.com, sudeep.holla@....com,
        linux@...linux.org.uk, gregkh@...uxfoundation.org, info@...ux.net,
        kstewart@...uxfoundation.org, allison@...utok.net,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        huangtao@...k-chips.com, Liang Chen <cl@...k-chips.com>
Subject: Re: [PATCH v1 1/1] sched/fair: do not preempt current task if it is
 going to call schedule()

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on arm64/for-next/core tip/auto-latest linus/master v5.6-rc4 next-20200305]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/cl-rock-chips-com/wait_task_inactive-spend-too-much-time-on-system-startup/20200305-201639
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git a0f03b617c3b2644d3d47bf7d9e60aed01bd5b10
config: riscv-randconfig-a001-20200305 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from arch/riscv/kernel/asm-offsets.c:10:0:
   include/linux/sched.h: In function 'set_tsk_going_to_sched':
   include/linux/sched.h:1776:27: error: 'TIF_GOING_TO_SCHED' undeclared (first use in this function); did you mean 'TIF_NEED_RESCHED'?
     set_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED);
                              ^~~~~~~~~~~~~~~~~~
                              TIF_NEED_RESCHED
   include/linux/sched.h:1776:27: note: each undeclared identifier is reported only once for each function it appears in
   include/linux/sched.h: In function 'clear_tsk_going_to_sched':
   include/linux/sched.h:1781:29: error: 'TIF_GOING_TO_SCHED' undeclared (first use in this function); did you mean 'TIF_NEED_RESCHED'?
     clear_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED);
                                ^~~~~~~~~~~~~~~~~~
                                TIF_NEED_RESCHED
   In file included from arch/riscv/include/asm/bug.h:9:0,
                    from include/linux/bug.h:5,
                    from arch/riscv/include/asm/current.h:13,
                    from include/linux/sched.h:12,
                    from arch/riscv/kernel/asm-offsets.c:10:
   include/linux/sched.h: In function 'test_tsk_going_to_sched':
   include/linux/sched.h:1786:44: error: 'TIF_GOING_TO_SCHED' undeclared (first use in this function); did you mean 'TIF_NEED_RESCHED'?
     return unlikely(test_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED));
                                               ^
   include/linux/compiler.h:33:34: note: in definition of macro '__branch_check__'
       ______r = __builtin_expect(!!(x), expect); \
                                     ^
>> include/linux/sched.h:1786:9: note: in expansion of macro 'unlikely'
     return unlikely(test_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED));
            ^~~~~~~~
   make[2]: *** [scripts/Makefile.build:101: arch/riscv/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1112: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:179: sub-make] Error 2
   21 real  5 user  9 sys  70.27% cpu 	make prepare

vim +/unlikely +1786 include/linux/sched.h

  1783	
  1784	static inline int test_tsk_going_to_sched(struct task_struct *tsk)
  1785	{
> 1786		return unlikely(test_tsk_thread_flag(tsk, TIF_GOING_TO_SCHED));
  1787	}
  1788	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (32719 bytes)