linux-kernel - Re: [PATCH 4.19 12/87] arm/ftrace: Fix BE text poking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Mar 2020 15:53:58 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pavel Machek <pavel@...x.de>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Dmitry Osipenko <digetx@...il.com>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>, Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 12/87] arm/ftrace: Fix BE text poking

On Thu, Mar 05, 2020 at 02:49:57PM +0100, Pavel Machek wrote:
> Hi!
> 
> > From: Peter Zijlstra <peterz@...radead.org>
> > 
> > [ Upstream commit be993e44badc448add6a18d6f12b20615692c4c3 ]
> > 
> > The __patch_text() function already applies __opcode_to_mem_*(), so
> > when __opcode_to_mem_*() is not the identity (BE*), it is applied
> > twice, wrecking the instruction.
> > 
> > Fixes: 42e51f187f86 ("arm/ftrace: Use __patch_text()")
> 
> I don't see 42e51f187f86 anywhere. Mainline contains
> 
> commit 5a735583b764750726621b0396d03e4782911b77
> Author: Peter Zijlstra <peterz@...radead.org>
> Date:   Tue Oct 15 21:07:35 2019 +0200
> 
>     arm/ftrace: Use __patch_text()
> 
> But that one is not present in 4.19, so perhaps we should not need
> this?

Good catch, I'll go drop this from everywhere.

I think Sasha has now fixed up his scripts to handle things when the
Fixes: tag does not point to a valid one.

thanks,

greg k-h