linux-kernel - Re: [PATCH] KVM: Drop gfn_to_pfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <2256821e496c45f5baf97f3f8f884d59@huawei.com>
Date:   Thu, 5 Mar 2020 01:52:24 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Peter Xu <peterx@...hat.com>
CC:     Paolo Bonzini <pbonzini@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>
Subject: Re: [PATCH] KVM: Drop gfn_to_pfn_atomic()

Peter Xu <peterx@...hat.com> writes:
>It's never used anywhere now.
>
>Signed-off-by: Peter Xu <peterx@...hat.com>
>---
> include/linux/kvm_host.h | 1 -
> virt/kvm/kvm_main.c      | 6 ------
> 2 files changed, 7 deletions(-)

It seems we prefer to use kvm_vcpu_gfn_to_pfn_atomic instead now. :)
Patch looks good, but maybe we should update Documentation/virt/kvm/locking.rst too:
In locking.rst:
	For direct sp, we can easily avoid it since the spte of direct sp is fixed
	to gfn. For indirect sp, before we do cmpxchg, we call gfn_to_pfn_atomic()
	to pin gfn to pfn, because after gfn_to_pfn_atomic()

Thanks.
Reviewed-by: Miaohe Lin <linmiaohe@...wei.com>