linux-kernel - Re: [RFC PATCH v1 3/3] dt-bindings: thermal: Add yaml bindings for thermal zones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqK_8MbxwKb9D4U0Cfv1m61zHWku4hJwiLaeOO6wkS8WCQ@mail.gmail.com>
Date:   Thu, 5 Mar 2020 09:37:54 -0600
From:   Rob Herring <robh@...nel.org>
To:     Amit Kucheria <amit.kucheria@...aro.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Linux PM list <linux-pm@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [RFC PATCH v1 3/3] dt-bindings: thermal: Add yaml bindings for
 thermal zones

On Thu, Mar 5, 2020 at 6:50 AM Amit Kucheria <amit.kucheria@...aro.org> wrote:
>
> On Tue, Feb 25, 2020 at 12:10 AM Rob Herring <robh@...nel.org> wrote:
> >
> > On Mon, 24 Feb 2020 12:55:37 +0530, Amit Kucheria wrote:
> > > As part of moving the thermal bindings to YAML, split it up into 3
> > > bindings: thermal sensors, cooling devices and thermal zones.
> > >
> > > The thermal-zone binding is a software abstraction to capture the
> > > properties of each zone - how often they should be checked, the
> > > temperature thresholds (trips) at which mitigation actions need to be
> > > taken and the level of mitigation needed at those thresholds.
> > >
> > > Signed-off-by: Amit Kucheria <amit.kucheria@...aro.org>
> > > ---
> > >  .../bindings/thermal/thermal-zones.yaml       | 302 ++++++++++++++++++
> > >  1 file changed, 302 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
>
> This one isn't due to my patch, I believe.

Right, that's the one known warning...

> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-zones.example.dt.yaml: thermal-sensor@...3000: interrupt-names: ['uplow'] is too short
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-zones.example.dt.yaml: thermal-sensor@...3000: interrupts: [[0, 506, 4]] is too short
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-zones.example.dt.yaml: thermal-sensor@...5000: interrupt-names: ['uplow'] is too short
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-zones.example.dt.yaml: thermal-sensor@...5000: interrupts: [[0, 507, 4]] is too short
>
> Fixed. Just for my information, did the check somehow figure out that
> this (incomplete) example needed the qcom-tsens.yaml binding (based on
> compatible string?) and then apply those rules to throw this error?

Yes. And setting DT_SCHEMA_FILES did change that to only check with
the specified schema file. However, that's now changed in linux-next
such that examples are always checked by all schemas and
DT_SCHEMA_FILES just limits which bindings to build and check.

Rob