linux-kernel - Re: [PATCH] spi: Remove CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e265e7df-fd8c-691f-389a-c0e0e377ed9e@huawei.com>
Date:   Thu, 5 Mar 2020 15:53:57 +0000
From:   John Garry <john.garry@...wei.com>
To:     Joe Perches <joe@...ches.com>
CC:     Mark Brown <broonie@...nel.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi: Remove CONFIG_ prefix from Kconfig select

On 05/03/2020 15:15, Joe Perches wrote:
> commit a2ca53b52e00 ("spi: Add HiSilicon v3xx SPI NOR flash
> controller driver") likely inadvertently used a select statement
> with a CONFIG_ prefix, remove the prefix.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

It's a pity checkpatch can't pick this stuff up...

The select is just for enabling the driver of a slave driver, so should 
not cause any build issues when not enabled. thanks

FWIW,
Acked-by: John Garry <john.garry@...wei.com>

> ---
>   drivers/spi/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 82177d..2dc7bd 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -292,7 +292,7 @@ config SPI_HISI_SFC_V3XX
>   	tristate "HiSilicon SPI-NOR Flash Controller for Hi16XX chipsets"
>   	depends on (ARM64 && ACPI) || COMPILE_TEST
>   	depends on HAS_IOMEM
> -	select CONFIG_MTD_SPI_NOR
> +	select MTD_SPI_NOR
>   	help
>   	  This enables support for HiSilicon v3xx SPI-NOR flash controller
>   	  found in hi16xx chipsets.
> 
> 
> .
>