linux-kernel - Re: [PATCH v2 1/2] mtd: spinand: toshiba: Rename function name to change suffix and prefix (8Gbit)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f6501db6-8dcd-ec13-de6a-b782656de0e7@kioxia.com>
Date:   Thu, 5 Mar 2020 11:43:23 +0900
From:   Yoshio Furuyama <ytc-mb-yfuruyama7@...xia.com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Schrempf Frieder <frieder.schrempf@...tron.de>
Cc:     "vigneshr@...com" <vigneshr@...com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] mtd: spinand: toshiba: Rename function name to
 change suffix and prefix (8Gbit)


On 2020/03/02 18:12, Miquel Raynal wrote:
> Hello,
>
> Schrempf Frieder <frieder.schrempf@...tron.de> wrote on Mon, 2 Mar 2020
> 08:02:25 +0000:
>
>> On 28.02.20 04:11, Yoshio Furuyama wrote:
>>> The suffix was changed to classify from "g" to "j" between 1st generation
>>> device and 2nd generation device that's new Serial NAND of Kioxia brand.
>> I had to read this sentence multiple times to understand it. Maybe
>> something like this would be better:
>>
>>     The suffix was changed from "g" to "j" to classify between 1st
>>     generation and 2nd generation serial NAND devices (which now belong to
>>     the Kioxia brand).
Thanks comment,     I will send revise rev.
>>> As reference that's
>>> 1st generation device of 1Gbit product is "tc58cvg0s3hraig"
>>> 2nd generation device of 1Gbit product is "tc58cvg0s3hraij".
>>>
>>> The 8Gbit product "TH58CxG3S0HRAIJ" is new line up of Kioxia's serial nand
>>> and changed the prefix from tc58 to th58.
>>> Thus it was changed argument to the function from "tc58cxgxsx" to
>>> "tx58cxgxsxraix".
>> Same here. It is very hard to read. I would write something like this:
>>
>>     The 8Gbit type "TH58CxG3S0HRAIJ" is new to Kioxia's serial NAND lineup
>>     and the prefix was changed from "TC58" to "TH85".
>>
>>     Thus the functions were renamed from tc58cxgxsx_*() to
>>     tx58cxgxsxraix_*().

I will change prefix from "TH85" to "TH58" .  Since this is typo.

    The 8Gbit type "TH58CxG3S0HRAIJ" is new to Kioxia's serial NAND lineup
    and the prefix was changed from "TC58" to "TH58".

    Thus the functions were renamed from tc58cxgxsx_*() to
    tx58cxgxsxraix_*().

Thanks,

>> With an easier to understand commit message:
>>
>> Reviewed-by: Frieder Schrempf <frieder.schrempf@...tron.de>
> Agreed, the commit log proposal from Frieder looks better.
>
> The rest of the patch is fine by me though.
>
> Thanks,
> Miquèl
>
>