linux-kernel - Re: [PATCH] ethernet:broadcom:bcm63xx_enet:remove redundant variable definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a419c6e1-47e8-64a0-4d58-9b2d8186f8bf@gmail.com>
Date:   Thu, 5 Mar 2020 09:27:49 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     tangbin <tangbin@...s.chinamobile.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ethernet:broadcom:bcm63xx_enet:remove redundant variable
 definitions

On 3/5/20 4:22 AM, tangbin wrote:
> in this function,‘ret’ is always assigned,so this's definition
> 'ret = 0' make no sense.
> 
> Signed-off-by: tangbin <tangbin@...s.chinamobile.com>

This looks fine, but your subject should be:

bcm63xx_enet: Remove redundant variable definitions

to matchthe majority of commit subjects done to that file. With that:

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian