linux-kernel - Re: [PATCH v2] mm: Make mem_cgroup_id_get_many() __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Mar 2020 18:36:14 +0000
From:   Chris Down <chris@...isdown.name>
To:     Vincenzo Frascino <vincenzo.frascino@....com>
Cc:     cgroups@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...nel.org>,
        Vladimir Davydov <vdavydov.dev@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] mm: Make mem_cgroup_id_get_many() __maybe_unused

Vincenzo Frascino writes:
>mem_cgroup_id_get_many() is currently used only when MMU or MEMCG_SWAP
>configuration options are enabled. Having them disabled triggers the
>following warning at compile time:
>
>linux/mm/memcontrol.c:4797:13: warning: ‘mem_cgroup_id_get_many’ defined
>but not used [-Wunused-function]
> static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned
> int n)
>
>Make mem_cgroup_id_get_many() __maybe_unused to address the issue.
>
>Cc: Johannes Weiner <hannes@...xchg.org>
>Cc: Michal Hocko <mhocko@...nel.org>
>Cc: Vladimir Davydov <vdavydov.dev@...il.com>
>Cc: Andrew Morton <akpm@...ux-foundation.org>
>Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>

Thanks, I didn't notice you've already posted it before replying on v1 :-)

Acked-by: Chris Down <chris@...isdown.name>

>---
> mm/memcontrol.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>index d09776cd6e10..2b9533ed52f5 100644
>--- a/mm/memcontrol.c
>+++ b/mm/memcontrol.c
>@@ -4794,7 +4794,8 @@ static void mem_cgroup_id_remove(struct mem_cgroup *memcg)
> 	}
> }
>
>-static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned int n)
>+static void __maybe_unused mem_cgroup_id_get_many(struct mem_cgroup *memcg,
>+						  unsigned int n)
> {
> 	refcount_add(n, &memcg->id.ref);
> }
>-- 
>2.25.1
>
>