linux-kernel - Re: [BUGFIX PATCH] tools: Let O= makes handle a relative path with -C option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200307031021.4e25253e7ff4aeb14b8a1095@kernel.org>
Date:   Sat, 7 Mar 2020 03:10:21 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Borislav Petkov <bp@...en8.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [BUGFIX PATCH] tools: Let O= makes handle a relative path with
 -C option

On Fri, 6 Mar 2020 08:26:43 -0800
Randy Dunlap <rdunlap@...radead.org> wrote:

> On 3/6/20 7:07 AM, Masami Hiramatsu wrote:
> > Thanks Geert,
> > 
> > So Randy, what you will get if you add "echo $(PWD)" instead of "cd $(PWD)" ?
> > Is that still empty or shows the tools/bootconfig directory?
> > 
> > Thanks,
> 
> OK, in these lines:
> +       dummy := $(if $(shell cd $(PWD); test -d $(O) || echo $(O)),$(error O=$(O) does not exist),)
> +       ABSOLUTE_O := $(shell cd $(PWD); cd $(O) ; pwd)
> 
> I changed both "cd $(PWD)" to "echo $(PWD)" and did
> $ make O=BUILD -C tools/bootconfig/
> 
> and this is the build log:
> 
> make: Entering directory '/home/rdunlap/lnx/next/linux-next-20200306/tools/bootconfig'
> cc ../../lib/bootconfig.c main.c -Wall -g -I./include -o bootconfig
> make: Leaving directory '/home/rdunlap/lnx/next/linux-next-20200306/tools/bootconfig'
> 
> 
> Does that help?

Hmm, did you apply "[PATCH 1/2] bootconfig: Support O=<builddir> option" too?

Also, I found this is not enough for perf. perf does more tricky thing in its Makefile.

Thank you,


-- 
Masami Hiramatsu <mhiramat@...nel.org>