linux-kernel - Re: [PATCH v6 1/3] MIPS: DTS: CI20: add DT node for IR sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1583519187.3.0@crapouillou.net>
Date:   Fri, 06 Mar 2020 19:26:27 +0100
From:   Paul Cercueil <paul@...pouillou.net>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Kees Cook <keescook@...omium.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        devicetree@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, letux-kernel@...nphoenux.org,
        Alex Smith <alex.smith@...tec.com>
Subject: Re: [PATCH v6 1/3] MIPS: DTS: CI20: add DT node for IR sensor

Hi Nikolaus,


Le ven., mars 6, 2020 at 18:29, H. Nikolaus Schaller 
<hns@...delico.com> a écrit :
> From: Alex Smith <alex.smith@...tec.com>
> 
> The infrared sensor on the CI20 board is connected to a GPIO and can
> be operated by using the gpio-ir-recv driver. Add a DT node for the
> sensor to allow that driver to be used.
> 
> Signed-off-by: Alex Smith <alex.smith@...tec.com>
> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> ---
>  arch/mips/boot/dts/ingenic/ci20.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts 
> b/arch/mips/boot/dts/ingenic/ci20.dts
> index c340f947baa0..e6ae08c979ea 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -62,6 +62,11 @@
>  		enable-active-high;
>  	};
> 
> +	ir: ir-receiver {

According to Documentation/devicetree/bindings/media/rc.yaml, the node 
should be named just "ir".

Cheers,
-Paul

> +		compatible = "gpio-ir-receiver";
> +		gpios = <&gpe 3 GPIO_ACTIVE_LOW>;
> +	};
> +
>  	wlan0_power: fixedregulator@1 {
>  		compatible = "regulator-fixed";
>  		regulator-name = "wlan0_power";
> --
> 2.23.0
>