linux-kernel - Re: [PATCH] platform: chrome: Fix cros-usbpd-notify notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200306184629.GA253583@google.com>
Date:   Fri, 6 Mar 2020 10:46:29 -0800
From:   Benson Leung <bleung@...gle.com>
To:     Gwendal Grignou <gwendal@...omium.org>
Cc:     bleung@...omium.org, enric.balletbo@...labora.com,
        jflat@...omium.org, linux-kernel@...r.kernel.org,
        pmalani@...omium.org
Subject: Re: [PATCH] platform: chrome: Fix cros-usbpd-notify notifier

Hi Gwendal,

On Wed, Mar 04, 2020 at 03:21:08PM -0800, Gwendal Grignou wrote:
> cros-usbpd-notify notifier was returning NOTIFY_BAD when no host event
> was available in the MKBP message.
> But MKBP messages are used to transmit other information, so return
> NOTIFY_DONE instead, to allow other notifier to be called.
> 
> Fixes: ec2daf6e33f9f ("platform: chrome: Add cros-usbpd-notify driver")
> 
> Signed-off-by: Gwendal Grignou <gwendal@...omium.org>

Queued for v5.7.

Thank you,
Benson

> ---
>  drivers/platform/chrome/cros_usbpd_notify.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/chrome/cros_usbpd_notify.c b/drivers/platform/chrome/cros_usbpd_notify.c
> index 3851bbd6e9a39..ca2c0181a1dbf 100644
> --- a/drivers/platform/chrome/cros_usbpd_notify.c
> +++ b/drivers/platform/chrome/cros_usbpd_notify.c
> @@ -84,7 +84,7 @@ static int cros_usbpd_notify_plat(struct notifier_block *nb,
>  	u32 host_event = cros_ec_get_host_event(ec_dev);
>  
>  	if (!host_event)
> -		return NOTIFY_BAD;
> +		return NOTIFY_DONE;
>  
>  	if (host_event & EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU)) {
>  		blocking_notifier_call_chain(&cros_usbpd_notifier_list,
> -- 
> 2.25.0.265.gbab2e86ba0-goog
> 

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@...gle.com
Chromium OS Project
bleung@...omium.org

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)