linux-kernel - Re: [PATCH v4 2/2] arm64: dts: rockchip: Add initial support for Pinebook Pro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Mar 2020 19:58:45 +0100
From:   Tobias Schramm <t.schramm@...jaro.org>
To:     Heiko Stuebner <heiko@...ech.de>,
        Tobias Schramm <t.schramm@...jaro.org>
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        Emmanuel Vadot <manu@...ebsd.org>,
        Alexis Ballier <aballier@...too.org>,
        Katsuhiro Suzuki <katsuhiro@...suster.net>,
        linux-kernel@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        Kever Yang <kever.yang@...k-chips.com>,
        Markus Reichl <m.reichl@...etechno.de>,
        linux-rockchip@...ts.infradead.org,
        Rob Herring <robh+dt@...nel.org>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Nick Xie <nick@...das.com>, Andy Yan <andy.yan@...k-chips.com>,
        Johan Jonker <jbx6244@...il.com>,
        Matthias Kaehlcke <mka@...omium.org>,
        Vivek Unune <npcomplete13@...il.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 2/2] arm64: dts: rockchip: Add initial support for
 Pinebook Pro

Hi Heiko,

>> This commit adds initial dt support for the rk3399 based Pinebook Pro.
>>
>> Signed-off-by: Tobias Schramm <t.schramm@...jaro.org>
>
> applied for 5.7
>

any chance you can squeeze in another small fix? Somewhere in the
process the vmcc and vqmmc supplies of the sdmmc controller were removed
in error. Those should be added to the sdmmc controller like this:

 &sdmmc {
        pinctrl-names = "default";
        pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>;
        sd-uhs-sdr104;
+       vmmc-supply = <&vcc3v0_sd>;
+       vqmmc-supply = <&vcc_sdio>;
        status = "okay";
 };

Thanks,

Tobias