linux-kernel - Re: [PATCH 00/12] Stitch LBR call stack (Perf Tools)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Mar 2020 14:13:15 -0500
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     acme@...nel.org, peterz@...radead.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org, namhyung@...nel.org,
        adrian.hunter@...el.com, mathieu.poirier@...aro.org,
        ravi.bangoria@...ux.ibm.com, alexey.budankov@...ux.intel.com,
        vitaly.slobodskoy@...el.com, pavel.gerasimov@...el.com,
        mpe@...erman.id.au, eranian@...gle.com, ak@...ux.intel.com
Subject: Re: [PATCH 00/12] Stitch LBR call stack (Perf Tools)



On 3/6/2020 4:39 AM, Jiri Olsa wrote:
> On Fri, Feb 28, 2020 at 08:29:59AM -0800, kan.liang@...ux.intel.com wrote:
> 
> SNIP
> 
>> Kan Liang (12):
>>    perf tools: Add hw_idx in struct branch_stack
>>    perf tools: Support PERF_SAMPLE_BRANCH_HW_INDEX
>>    perf header: Add check for event attr
>>    perf pmu: Add support for PMU capabilities
> 
> hi,
> I'm getting compile error:
> 
> 	util/pmu.c: In function ‘perf_pmu__caps_parse’:
> 	util/pmu.c:1620:32: error: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size between 0 and 4095 [-Werror=format-truncation=]
> 	 1620 |   snprintf(path, PATH_MAX, "%s/%s", caps_path, name);
> 	      |                                ^~
> 	In file included from /usr/include/stdio.h:867,
> 			 from util/pmu.c:12:
> 	/usr/include/bits/stdio2.h:67:10: note: ‘__builtin___snprintf_chk’ output between 2 and 4352 bytes into a destination of size 4096
> 	   67 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
> 	      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 	   68 |        __bos (__s), __fmt, __va_arg_pack ());
> 	      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 	cc1: all warnings being treated as errors
> 
> 	[jolsa@...va perf]$ gcc --version
> 	gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1)

My GCC version is too old. I will send V2 later to fix the error.

Thanks,
Kan

> 
> jirka
>