linux-kernel - Re: [RFC,net-next 3/9] net: schedule: add action gate offloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200306111914.746d9bb3@kicinski-fedora-PC1C0HJN>
Date:   Fri, 6 Mar 2020 11:19:19 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Po Liu <Po.Liu@....com>
Cc:     davem@...emloft.net, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, vinicius.gomes@...el.com,
        claudiu.manoil@....com, vladimir.oltean@....com,
        alexandru.marginean@....com, xiaoliang.yang_1@....com,
        roy.zang@....com, mingkai.hu@....com, jerry.huang@....com,
        leoyang.li@....com, michael.chan@...adcom.com, vishal@...lsio.com,
        saeedm@...lanox.com, leon@...nel.org, jiri@...lanox.com,
        idosch@...lanox.com, alexandre.belloni@...tlin.com,
        UNGLinuxDriver@...rochip.com, jhs@...atatu.com,
        xiyou.wangcong@...il.com, john.hurley@...ronome.com,
        simon.horman@...ronome.com, pieter.jansenvanvuuren@...ronome.com,
        pablo@...filter.org, moshe@...lanox.com,
        ivan.khoronzhuk@...aro.org, m-karicheri2@...com,
        andre.guedes@...ux.intel.com, jakub.kicinski@...ronome.com
Subject: Re: [RFC,net-next  3/9] net: schedule: add action gate offloading

On Fri, 6 Mar 2020 11:02:00 -0800 Jakub Kicinski wrote:
> On Fri,  6 Mar 2020 20:56:01 +0800 Po Liu wrote:
> > +static int tcf_gate_get_entries(struct flow_action_entry *entry,
> > +				const struct tc_action *act)
> > +{
> > +	entry->gate.entries = tcf_gate_get_list(act);
> > +
> > +	if (!entry->gate.entries)
> > +		return -EINVAL;
> > +
> > +	entry->destructor = tcf_gate_entry_destructor;
> > +	entry->destructor_priv = entry->gate.entries;  
> 
> What's this destructor stuff doing? I don't it being called.

Ah, it's the action destructor, not something gate specific. Disregard.