linux-kernel - Re: [PATCH v2] uacce: unmap remaining mmapping from user space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a8beaf1f-a510-7fca-d048-1327c87226fa@linaro.org>
Date:   Fri, 6 Mar 2020 10:36:52 +0800
From:   zhangfei <zhangfei.gao@...aro.org>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>, jonathan.cameron@...wei.com,
        dave.jiang@...el.com, grant.likely@....com,
        jean-philippe <jean-philippe@...aro.org>,
        Jerome Glisse <jglisse@...hat.com>,
        ilias.apalodimas@...aro.org, francois.ozog@...aro.org,
        kenneth-lee-2012@...mail.com, Wangzhou <wangzhou1@...ilicon.com>,
        "haojian . zhuang" <haojian.zhuang@...aro.org>,
        guodong.xu@...aro.org, linux-accelerators@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        iommu@...ts.linux-foundation.org
Subject: Re: [PATCH v2] uacce: unmap remaining mmapping from user space



On 2020/3/6 上午9:51, Herbert Xu wrote:
> On Wed, Feb 26, 2020 at 03:12:06PM +0800, Zhangfei Gao wrote:
>> When uacce parent device module is removed, user app may
>> still keep the mmaped area, which can be accessed unsafely.
>> When rmmod, Parent device driver will call uacce_remove,
>> which unmap all remaining mapping from user space for safety.
>> VM_FAULT_SIGBUS is also reported to user space accordingly.
>>
>> Suggested-by: Dave Jiang <dave.jiang@...el.com>
>> Signed-off-by: Zhangfei Gao <zhangfei.gao@...aro.org>
>> ---
>>   v2: Unmap before put_queue, where memory is freed, commented from Zaibo.
>>
>>   drivers/misc/uacce/uacce.c | 16 ++++++++++++++++
>>   include/linux/uacce.h      |  2 ++
>>   2 files changed, 18 insertions(+)
> Patch applied.  Thanks.
Thanks Herbert for the help.