linux-kernel - Re: [PATCH v2] scsi: sr: get rid of sr global mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <8df4a060-0576-ebeb-f3f4-cc35fcbef3e2@0882a8b5-c6c3-11e9-b005-00805fc181fe>
Date:   Fri, 6 Mar 2020 22:43:02 +0000
From:   Simon Arlott <simon@...iron.net>
To:     "Merlijn B.W. Wajer" <merlijn@...hive.org>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Jens Axboe <jens.axboe@...cle.com>,
        James Bottomley <jejb@...ux.ibm.com>
Cc:     linux-scsi@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH v2] scsi: sr: get rid of sr global mutex

On 24/02/2020 21:20, Merlijn B.W. Wajer wrote:
> Just wanted to check if you planned to apply this v2 (you tried to apply
> v1 but it didn't compile, so I rebased it onto 5.7/scsi-queue as you
> requested). Please let me know if there's anything you'd like to see
> changed.

There's a missing call to mutex_destroy(&cd->lock) in sr_probe() if
there are any failures after calling mutex_init(&cd->lock).

> On 18/02/2020 20:21, Merlijn B.W. Wajer wrote:
>> Perhaps I or someone else can work on removing the usage of the locks,
>> but as it stands I think this addresses the performance issue present in
>> the current kernel, and removing locks and the associated testing
>> required with that is something I am not entirely comfortable doing.

I have a patch to move the locks into the cdrom driver and I've got
multiple PATA drives to test it with.

-- 
Simon Arlott