linux-kernel - Re: [PATCH V2 2/2] f2fs: Add a new CP flag to help fsck fix resize SPO issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200306030327.GH20234@codeaurora.org>
Date:   Fri, 6 Mar 2020 08:33:27 +0530
From:   Sahitya Tummala <stummala@...eaurora.org>
To:     Chao Yu <yuchao0@...wei.com>
Cc:     Jaegeuk Kim <jaegeuk@...nel.org>,
        linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 2/2] f2fs: Add a new CP flag to help fsck fix resize
 SPO issues

Hi Chao,

On Fri, Mar 06, 2020 at 09:19:39AM +0800, Chao Yu wrote:
> On 2020/3/3 22:29, Sahitya Tummala wrote:
> > Add and set a new CP flag CP_RESIZEFS_FLAG during
> > online resize FS to help fsck fix the metadata mismatch
> > that may happen due to SPO during resize, where SB
> > got updated but CP data couldn't be written yet.
> > 
> > fsck errors -
> > Info: CKPT version = 6ed7bccb
> >         Wrong user_block_count(2233856)
> > [f2fs_do_mount:3365] Checkpoint is polluted
> 
> I'm not against this patch, however without this change, could
> fsck have any chance to repair old image?

Sure, I will update the fsck patch to handle it.

thanks,
> 
> > 
> > Signed-off-by: Sahitya Tummala <stummala@...eaurora.org>
> 
> Reviewed-by: Chao Yu <yuchao0@...wei.com>

-- 
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.