[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAEUhbmWLNi+vAFjjHLNKQ-PfMUusEEorVN7S8sK0yZhEAUk3Fg@mail.gmail.com>
Date: Fri, 6 Mar 2020 13:43:57 +0800
From: Bin Meng <bmeng.cn@...il.com>
To: Atish Patra <atish.patra@....com>
Cc: linux-kernel <linux-kernel@...r.kernel.org>,
Kate Stewart <kstewart@...uxfoundation.org>,
Madhavan Srinivasan <maddy@...ux.vnet.ibm.com>,
Zong Li <zong.li@...ive.com>,
Palmer Dabbelt <palmerdabbelt@...gle.com>,
Heiko Carstens <heiko.carstens@...ibm.com>,
Michael Kelley <mikelley@...rosoft.com>,
Gary Guo <gary@...yguo.net>,
linux-riscv <linux-riscv@...ts.infradead.org>,
Mike Rapoport <rppt@...ux.ibm.com>,
Kees Cook <keescook@...omium.org>,
Marc Zyngier <maz@...nel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
Daniel Jordan <daniel.m.jordan@...cle.com>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
Greentime Hu <greentime.hu@...ive.com>,
Borislav Petkov <bp@...e.de>, Mao Han <han_mao@...ky.com>,
Albert Ou <aou@...s.berkeley.edu>,
Jason Cooper <jason@...edaemon.net>,
Sudeep Holla <sudeep.holla@....com>,
Alexios Zavras <alexios.zavras@...el.com>,
Paul Walmsley <paul.walmsley@...ive.com>,
Thomas Gleixner <tglx@...utronix.de>,
Nick Hu <nickhu@...estech.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Vincent Chen <vincent.chen@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
Anup Patel <anup@...infault.org>,
Steven Price <steven.price@....com>
Subject: Re: [PATCH v10 01/12] RISC-V: Mark existing SBI as 0.1 SBI.
On Thu, Feb 27, 2020 at 6:02 AM Atish Patra <atish.patra@....com> wrote:
>
> As per the new SBI specification, current SBI implementation version
> is defined as 0.1 and will be removed/replaced in future. Each of the
> function call in 0.1 is defined as a separate extension which makes
> easier to replace them one at a time.
>
> Rename existing implementation to reflect that. This patch is just
> a preparatory patch for SBI v0.2 and doesn't introduce any functional
> changes.
>
> Signed-off-by: Atish Patra <atish.patra@....com>
> Reviewed-by: Anup Patel <anup@...infault.org>
> Reviewed-by: Palmer Dabbelt <palmerdabbelt@...gle.com>
> ---
> arch/riscv/include/asm/sbi.h | 44 ++++++++++++++++++++----------------
> 1 file changed, 24 insertions(+), 20 deletions(-)
>
> diff --git a/arch/riscv/include/asm/sbi.h b/arch/riscv/include/asm/sbi.h
> index 2570c1e683d3..3db30e739c8f 100644
> --- a/arch/riscv/include/asm/sbi.h
> +++ b/arch/riscv/include/asm/sbi.h
> @@ -1,6 +1,7 @@
> /* SPDX-License-Identifier: GPL-2.0-only */
> /*
> * Copyright (C) 2015 Regents of the University of California
> + * Copyright (c) 2020 Western Digital Corporation or its affiliates.
> */
>
> #ifndef _ASM_RISCV_SBI_H
> @@ -9,17 +10,17 @@
> #include <linux/types.h>
>
> #ifdef CONFIG_RISCV_SBI
> -#define SBI_SET_TIMER 0
> -#define SBI_CONSOLE_PUTCHAR 1
> -#define SBI_CONSOLE_GETCHAR 2
> -#define SBI_CLEAR_IPI 3
> -#define SBI_SEND_IPI 4
> -#define SBI_REMOTE_FENCE_I 5
> -#define SBI_REMOTE_SFENCE_VMA 6
> -#define SBI_REMOTE_SFENCE_VMA_ASID 7
> -#define SBI_SHUTDOWN 8
> +#define SBI_EXT_0_1_SET_TIMER 0x0
> +#define SBI_EXT_0_1_CONSOLE_PUTCHAR 0x1
> +#define SBI_EXT_0_1_CONSOLE_GETCHAR 0x2
> +#define SBI_EXT_0_1_CLEAR_IPI 0x3
> +#define SBI_EXT_0_1_SEND_IPI 0x4
> +#define SBI_EXT_0_1_REMOTE_FENCE_I 0x5
> +#define SBI_EXT_0_1_REMOTE_SFENCE_VMA 0x6
> +#define SBI_EXT_0_1_REMOTE_SFENCE_VMA_ASID 0x7
> +#define SBI_EXT_0_1_SHUTDOWN 0x8
>
> -#define SBI_CALL(which, arg0, arg1, arg2, arg3) ({ \
> +#define SBI_CALL(which, arg0, arg1, arg2, arg3) ({ \
nits: this line should not be changed
> register uintptr_t a0 asm ("a0") = (uintptr_t)(arg0); \
> register uintptr_t a1 asm ("a1") = (uintptr_t)(arg1); \
> register uintptr_t a2 asm ("a2") = (uintptr_t)(arg2); \
> @@ -43,48 +44,50 @@
>
[snip]
Regards,
Bin
Powered by blists - more mailing lists