linux-kernel - Re: [PATCH] drm: komeda: Make rt_pm_ops dependent on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be7a17bf-86f8-a086-9783-3f4a211cf9e3@arm.com>
Date:   Fri, 6 Mar 2020 09:52:25 +0000
From:   Vincenzo Frascino <vincenzo.frascino@....com>
To:     Liviu Dudau <liviu.dudau@....com>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        "James (Qian) Wang" <james.qian.wang@....com>,
        Mihail Atanassov <mihail.atanassov@....com>,
        Brian Starkey <brian.starkey@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH] drm: komeda: Make rt_pm_ops dependent on CONFIG_PM

Hi Liviu,

On 3/5/20 6:42 PM, Liviu Dudau wrote:
> On Wed, Mar 04, 2020 at 02:54:12PM +0000, Vincenzo Frascino wrote:
>> komeda_rt_pm_suspend() and komeda_rt_pm_resume() are compiled only when
>> CONFIG_PM is enabled. Having it disabled triggers the following warning
>> at compile time:
>>
>> linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:156:12:
>> warning: ‘komeda_rt_pm_resume’ defined but not used [-Wunused-function]
>>  static int komeda_rt_pm_resume(struct device *dev)
>>             ^~~~~~~~~~~~~~~~~~~
>> linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:149:12:
>> warning: ‘komeda_rt_pm_suspend’ defined but not used [-Wunused-function]
>>  static int komeda_rt_pm_suspend(struct device *dev)
>>
>> Make komeda_rt_pm_suspend() and komeda_rt_pm_resume() dependent on
>> CONFIG_PM to address the issue.
>>
>> Cc: "James (Qian) Wang" <james.qian.wang@....com>
>> Cc: Liviu Dudau <liviu.dudau@....com>
>> Cc: Mihail Atanassov <mihail.atanassov@....com>
>> Cc: Brian Starkey <brian.starkey@....com>
>> Cc: David Airlie <airlied@...ux.ie>
>> Cc: Daniel Vetter <daniel@...ll.ch>
>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>
> 
> Acked-by: Liviu Dudau <liviu.dudau@....com>
> 
> Thanks for the patch, I will push it into drm-misc-fixes tomorrow.
> 

Thank you!

> Best regards,
> Liviu
> 
>> ---
>>  drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
>> index ea5cd1e17304..dd3ae3d88687 100644
>> --- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
>> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
>> @@ -146,6 +146,7 @@ static const struct of_device_id komeda_of_match[] = {
>>  
>>  MODULE_DEVICE_TABLE(of, komeda_of_match);
>>  
>> +#ifdef CONFIG_PM
>>  static int komeda_rt_pm_suspend(struct device *dev)
>>  {
>>  	struct komeda_drv *mdrv = dev_get_drvdata(dev);
>> @@ -159,6 +160,7 @@ static int komeda_rt_pm_resume(struct device *dev)
>>  
>>  	return komeda_dev_resume(mdrv->mdev);
>>  }
>> +#endif /* CONFIG_PM */
>>  
>>  static int __maybe_unused komeda_pm_suspend(struct device *dev)
>>  {
>> -- 
>> 2.25.1
>>
> 

-- 
Regards,
Vincenzo