lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 6 Mar 2020 11:26:39 +0100 From: Arend Van Spriel <arend.vanspriel@...adcom.com> To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>, Franky Lin <franky.lin@...adcom.com>, Hante Meuleman <hante.meuleman@...adcom.com>, Chi-Hsien Lin <chi-hsien.lin@...ress.com>, Wright Feng <wright.feng@...ress.com>, Kalle Valo <kvalo@...eaurora.org>, "David S. Miller" <davem@...emloft.net> Cc: linux-wireless@...r.kernel.org, brcm80211-dev-list.pdl@...adcom.com, brcm80211-dev-list@...ress.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH][next] brcmfmac: Replace zero-length array with flexible-array member On 2/25/2020 3:08 AM, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99: [...] > "Flexible array members have incomplete type, and so the sizeof operator > may not be applied. As a quirk of the original implementation of > zero-length arrays, sizeof evaluates to zero."[1] > > This issue was found with the help of Coccinelle. > > [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > [2] https://github.com/KSPP/linux/issues/21 > [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com> > Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.h | 2 +- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-)
Powered by blists - more mailing lists