| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAA93ih0F4ZgP3_NskrBNc8Exazv52wYn+QFYH02pireVrAPRYQ@mail.gmail.com>
Date: Fri, 6 Mar 2020 19:48:49 +0900
From: Masami Hiramatsu <masami.hiramatsu@...aro.org>
To: Naresh Kamboju <naresh.kamboju@...aro.org>
Cc: open list <linux-kernel@...r.kernel.org>,
Anders Roxell <anders.roxell@...aro.org>, paulmck@...nel.org,
"Steven Rostedt (Red Hat)" <rostedt@...dmis.org>,
Ingo Molnar <mingo@...hat.com>,
Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Stephen Rothwell <sfr@...b.auug.org.au>,
lkft-triage@...ts.linaro.org
Subject: Re: WARNING: suspicious RCU usage 5.6.0-rc4-next-20200305 -
kprobes.c:2240 RCU-list traversed in non-reader section
Hi Naresh,
Thank you for reporting!
It is from new RCU-list debugging feature. For the kprobes I've
already sent the patch but no response yet.
https://lkml.org/lkml/2020/2/26/167
And as the following patch shows, it is easy to fix those.
https://lkml.org/lkml/2020/2/26/168
- find a lock (mutex) which protects the list and add lockdep_is_held(), or
- add rcu_read_lock/unlock() around the list operation.
The former case is a false positive, the latter one is a real bug.
Thank you,
2020年3月6日(金) 18:50 Naresh Kamboju <naresh.kamboju@...aro.org>:
>
> Regression on Linux next 5.6.0-rc4-next-20200305
> the "WARNING: suspicious RCU usage" on x86_64, i386, arm and arm64 boot log.
>
> Steps to reproduce,
> Boot linux next tag version 20200305 and on boot you notice below RCU warning.
>
> x86_boot log,
> --------------------
> [ 0.000000] Linux version 5.6.0-rc4-next-20200305 (oe-user@...host)
> (gcc version 7.3.0 (GCC)) #1 SMP Thu Mar 5 07:09:13 UTC 2020
> [ 0.000000] Command line: root=/dev/nfs rw
> nfsroot=10.66.16.116:/var/lib/lava/dispatcher/tmp/1269574/extract-nfsrootfs-nqxjbzn7,tcp,hard,intr
> ip=dhcp console=ttyS0,115200n8 lava_mac=00:90:05:af:00:7d
> <trim>
> [ 2.960824] =============================
> [ 2.964838] WARNING: suspicious RCU usage
> [ 2.968860] 5.6.0-rc4-next-20200305 #1 Not tainted
> [ 2.973659] -----------------------------
> [ 2.977670] /usr/src/kernel/drivers/iommu/dmar.c:366 RCU-list
> traversed in non-reader section!!
> [ 2.986366]
> [ 2.986366] other info that might help us debug this:
> [ 2.986366]
> [ 2.994372]
> [ 2.994372] rcu_scheduler_active = 2, debug_locks = 1
> [ 3.000899] 1 lock held by swapper/0/1:
> [ 3.004736] #0: ffffffffb6330aa8 (dmar_global_lock){+.+.}, at:
> intel_iommu_init+0x14f/0x1610
> [ 3.013275]
> [ 3.013275] stack backtrace:
> [ 3.017635] CPU: 2 PID: 1 Comm: swapper/0 Not tainted
> 5.6.0-rc4-next-20200305 #1
> [ 3.018630] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS
> 2.0b 07/27/2017
> [ 3.018630] Call Trace:
> [ 3.018630] dump_stack+0x7a/0xa5
> [ 3.018630] lockdep_rcu_suspicious+0xc5/0x100
> [ 3.018630] dmar_find_dmaru+0x7f/0x90
> [ 3.018630] dmar_parse_one_drhd+0x21/0x550
> [ 3.018630] dmar_walk_remapping_entries+0xa6/0x1d0
> [ 3.018630] ? e820__memblock_setup+0x8c/0x8c
> [ 3.018630] ? rdinit_setup+0x30/0x30
> [ 3.018630] dmar_table_init+0xc8/0x157
> [ 3.018630] ? dmar_free_dev_scope+0xe0/0xe0
> [ 3.018630] ? intel_iommu_setup+0x21b/0x21b
> [ 3.018630] ? __intel_map_single+0x210/0x210
> [ 3.018630] ? dmar_find_dmaru+0x90/0x90
> [ 3.018630] ? amd_iommu_apply_ivrs_quirks+0x17/0x17
> [ 3.018630] intel_iommu_init+0x154/0x1610
> [ 3.018630] ? lockdep_hardirqs_on+0xf6/0x190
> [ 3.018630] ? kfree+0x184/0x2e0
> [ 3.018630] ? trace_hardirqs_on+0x4c/0x100
> [ 3.018630] ? unpack_to_rootfs+0x296/0x2c0
> [ 3.018630] ? rdinit_setup+0x30/0x30
> [ 3.018630] ? e820__memblock_setup+0x8c/0x8c
> [ 3.018630] ? rdinit_setup+0x30/0x30
> [ 3.018630] pci_iommu_init+0x1a/0x44
> [ 3.018630] ? pci_iommu_init+0x1a/0x44
> [ 3.018630] do_one_initcall+0x61/0x2f0
> [ 3.018630] ? rdinit_setup+0x30/0x30
> [ 3.018630] ? rcu_read_lock_sched_held+0x4f/0x80
> [ 3.018630] kernel_init_freeable+0x219/0x279
> [ 3.018630] ? rest_init+0x250/0x250
> [ 3.018630] kernel_init+0xe/0x110
> [ 3.018630] ret_from_fork+0x3a/0x50
> <trim>
> [ 13.765411] =============================
> [ 13.765412] WARNING: suspicious RCU usage
> [ 13.765413] 5.6.0-rc4-next-20200305 #1 Not tainted
> [ 13.765414] -----------------------------
> [ 13.765415] /usr/src/kernel/kernel/kprobes.c:2240 RCU-list
> traversed in non-reader section!!
> [ 13.765416]
> [ 13.765416] other info that might help us debug this:
> [ 13.765416]
> [ 13.765417]
> [ 13.765417] rcu_scheduler_active = 2, debug_locks = 1
> [ 13.765418] 2 locks held by systemd-modules/164:
> [ 13.765418] #0: ffffffffb62834e8
> ((module_notify_list).rwsem){++++}, at:
> blocking_notifier_call_chain+0x2f/0x70
> [ 13.765423] #1: ffffffffb628abe0 (kprobe_mutex){+.+.}, at:
> kprobes_module_callback+0x41/0x250
> [ 13.765427]
> [ 13.765427] stack backtrace:
> [ 13.765429] CPU: 3 PID: 164 Comm: systemd-modules Not tainted
> 5.6.0-rc4-next-20200305 #1
> [ 13.765430] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS
> 2.0b 07/27/2017
> [ 13.765431] Call Trace:
> [ 13.765434] dump_stack+0x7a/0xa5
> [ 13.765437] lockdep_rcu_suspicious+0xc5/0x100
> [ 13.765442] kprobes_module_callback+0x1b7/0x250
> [ 13.765445] notifier_call_chain+0x4c/0x70
> [ 13.765449] blocking_notifier_call_chain+0x49/0x70
> [ 13.765453] do_init_module+0xa4/0x226
> [ 13.765456] load_module+0x24e6/0x2ac0
> [ 13.765472] __do_sys_finit_module+0xfc/0x120
> [ 13.884088] ? __do_sys_finit_module+0xfc/0x120
> [ 13.888629] __x64_sys_finit_module+0x1a/0x20
> [ 13.892980] do_syscall_64+0x55/0x200
> [ 13.896638] entry_SYSCALL_64_after_hwframe+0x49/0xbe
> [ 13.901689] RIP: 0033:0x7fe279551f59
> [ 13.905259] Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00
> 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24
> 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 0f ff 2b 00 f7 d8 64 89
> 01 48
> [ 13.923998] RSP: 002b:00007ffd2560f0e8 EFLAGS: 00000206 ORIG_RAX:
> 0000000000000139
> [ 13.931564] RAX: ffffffffffffffda RBX: 000055d618061400 RCX: 00007fe279551f59
> [ 13.938694] RDX: 0000000000000000 RSI: 00007fe2798266a3 RDI: 0000000000000005
> [ 13.945819] RBP: 00007fe2798266a3 R08: 0000000000000000 R09: 0000000000000000
> [ 13.952942] R10: 0000000000000005 R11: 0000000000000206 R12: 0000000000000000
> [ 13.960066] R13: 0000000000020000 R14: 000055d617dab004 R15: 00007ffd2560f220
>
> Full boot log link,
> https://lkft.validation.linaro.org/scheduler/job/1269574#L1095
>
> metadata:
> git repo: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> git branch: master
> git describe: next-20200305
> make_kernelversion: 5.6.0-rc4
> kernel-config:
> http://snapshots.linaro.org/openembedded/lkft/lkft/sumo/intel-corei7-64/lkft/linux-next/719/config
>
> --
> Linaro LKFT
> https://lkft.linaro.org
--
Masami Hiramatsu
Powered by blists - more mailing lists