linux-kernel - Re: [PATCH v5 3/3] hwmon: add Gateworks System Controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Mar 2020 08:07:54 -0800
From:   Tim Harvey <tharvey@...eworks.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Lee Jones <lee.jones@...aro.org>, Jean Delvare <jdelvare@...e.com>,
        linux-hwmon@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        devicetree@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>,
        Robert Jones <rjones@...eworks.com>
Subject: Re: [PATCH v5 3/3] hwmon: add Gateworks System Controller support

On Tue, Mar 3, 2020 at 12:54 PM Guenter Roeck <linux@...ck-us.net> wrote:
>
> On Mon, Feb 24, 2020 at 12:54:25PM -0800, Tim Harvey wrote:
> > The Gateworks System Controller has a hwmon sub-component that exposes
> > up to 16 ADC's, some of which are temperature sensors, others which are
> > voltage inputs. The ADC configuration (register mapping and name) is
> > configured via device-tree and varies board to board.
> >
> > Cc: Guenter Roeck <linux@...ck-us.net>
> > Signed-off-by: Tim Harvey <tharvey@...eworks.com>
>
> Couple of minor comments, otherwise looks good from my perspective.
>

Guenter,

Thank you for the review! I will post a v6 as soon as I get the dt
bindings worked through.

Tim