linux-kernel - Re: [PATCH] xen: Use evtchn_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <721d9950-eec6-9da4-1bfb-e615629fe66e@oracle.com>
Date:   Fri, 6 Mar 2020 11:08:13 -0500
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Yan Yankovskyi <yyankovskyi@...il.com>,
        Jan Beulich <jbeulich@...e.com>
Cc:     Juergen Gross <jgross@...e.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xen: Use evtchn_type_t as a type for event channels



On 3/5/20 4:57 AM, Yan Yankovskyi wrote:
> Make event channel functions pass event channel port using
> evtchn_port_t type. It eliminates signed <-> unsigned conversion.
> Also rename 'evtchn' variables to 'port' in case if 'port' is not
> ambiguous.


> @@ -171,10 +171,10 @@ static int xen_irq_info_common_setup(struct irq_info *info,
>  
>  	info->type = type;
>  	info->irq = irq;
> -	info->evtchn = evtchn;
> +	info->evtchn = port;

Hmm... I am not sure these kinds of changes make it much better.


-boris