linux-kernel - Re: [PATCH 03/23] mtd: spi-nor: Move SFDP logic out of the core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200307155026.20deb026@collabora.com>
Date:   Sat, 7 Mar 2020 15:50:26 +0100
From:   Boris Brezillon <boris.brezillon@...labora.com>
To:     <Tudor.Ambarus@...rochip.com>
Cc:     <bbrezillon@...nel.org>, <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, kstewart@...uxfoundation.org,
        alexandre.belloni@...tlin.com, linux-aspeed@...ts.ozlabs.org,
        thor.thayer@...ux.intel.com, jethro@...tanix.com,
        rfontana@...hat.com, miquel.raynal@...tlin.com,
        opensource@...ayne.com, richard@....at, michal.simek@...inx.com,
        Ludovic.Desroches@...rochip.com, joel@....id.au,
        nishkadg.linux@...il.com, john.garry@...wei.com, vz@...ia.com,
        alexander.sverdlin@...ia.com, matthias.bgg@...il.com,
        tglx@...utronix.de, swboyd@...omium.org,
        mika.westerberg@...ux.intel.com, allison@...utok.net,
        linux-arm-kernel@...ts.infradead.org, andrew@...id.au,
        Nicolas.Ferre@...rochip.com, linux-kernel@...r.kernel.org,
        dinguyen@...nel.org, michael@...le.cc, ludovic.barre@...com,
        linux-mediatek@...ts.infradead.org, info@...ux.net
Subject: Re: [PATCH 03/23] mtd: spi-nor: Move SFDP logic out of the core

On Mon, 2 Mar 2020 18:07:46 +0000
<Tudor.Ambarus@...rochip.com> wrote:

> From: Tudor Ambarus <tudor.ambarus@...rochip.com>
> 
> It makes the core file a bit smaller and provides better separation
> between the SFDP parsing and core logic.
> 
> Keep the core.h and sfdp.h definitions private in drivers/mtd/spi-nor/.
> Both expose just the definitions that are required by the core and
> manufacturer drivers. None of the SPI NOR controller drivers should
> include them.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@...rochip.com>

Reviewed-by: Boris Brezillon <boris.brezillon@...labora.com>