| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20200307225335.31300-1-mateusznosek0@gmail.com> Date: Sat, 7 Mar 2020 23:53:35 +0100 From: mateusznosek0@...il.com To: linux-mm@...ck.org, linux-kernel@...r.kernel.org Cc: Mateusz Nosek <mateusznosek0@...il.com>, akpm@...ux-foundation.org Subject: [RFC PATCH] mm/page_alloc.c: Micro-optimisation Remove unnecessary branch From: Mateusz Nosek <mateusznosek0@...il.com> Previously if branch condition was false, the assignment was not executed. The assignment can be safely executed even when the condition is false and it is not incorrect as it assigns the value of 'nodemask' to 'ac.nodemask' which already has the same value. So as the assignment can be executed unconditionally, the branch can be removed. Signed-off-by: Mateusz Nosek <mateusznosek0@...il.com> --- mm/page_alloc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 79e950d76ffc..75456d04b5c5 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -4819,8 +4819,7 @@ __alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order, int preferred_nid, * Restore the original nodemask if it was potentially replaced with * &cpuset_current_mems_allowed to optimize the fast-path attempt. */ - if (unlikely(ac.nodemask != nodemask)) - ac.nodemask = nodemask; + ac.nodemask = nodemask; page = __alloc_pages_slowpath(alloc_mask, order, &ac); -- 2.17.1
Powered by blists - more mailing lists