linux-kernel - Re: [PATCH v3 4/4] drm/bridge: anx7688: Add ANX7688 bridge driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202003070802.J9O1wS4g%lkp@intel.com>
Date:   Sat, 7 Mar 2020 09:04:04 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Collabora Kernel ML <kernel@...labora.com>,
        Andrzej Hajda <a.hajda@...sung.com>, megous@...ous.com,
        anarsoul@...il.com, Neil Armstrong <narmstrong@...libre.com>,
        matthias.bgg@...il.com, drinkcat@...omium.org, hsinyi@...omium.org,
        icenowy@...c.io, David Airlie <airlied@...ux.ie>,
        Jonas Karlman <jonas@...boo.se>,
        dri-devel@...ts.freedesktop.org, Maxime Ripard <maxime@...no.tech>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        Torsten Duwe <duwe@...e.de>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH v3 4/4] drm/bridge: anx7688: Add ANX7688 bridge driver
 support

Hi Enric,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on ljones-mfd/for-mfd-next]
[also build test ERROR on robh/for-next linus/master v5.6-rc4 next-20200305]
[cannot apply to linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Enric-Balletbo-i-Serra/dt-bindings-Add-binding-for-the-Analogix-ANX7688-chip/20200307-045427
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: i386-randconfig-e001-20200305 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/bridge/analogix/analogix-anx7688.c: In function 'anx7688_bridge_probe':
>> drivers/gpu/drm/bridge/analogix/analogix-anx7688.c:89:14: error: 'struct drm_bridge' has no member named 'of_node'
     data->bridge.of_node = dev->of_node;
                 ^

vim +89 drivers/gpu/drm/bridge/analogix/analogix-anx7688.c

    78	
    79	static int anx7688_bridge_probe(struct platform_device *pdev)
    80	{
    81		struct anx7688 *anx7688 = dev_get_drvdata(pdev->dev.parent);
    82		struct anx7688_bridge_data *data;
    83		struct device *dev = &pdev->dev;
    84	
    85		data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
    86		if (!data)
    87			return -ENOMEM;
    88	
  > 89		data->bridge.of_node = dev->of_node;
    90		data->regmap = anx7688->regmap;
    91	
    92		/* FW version >= 0.85 supports bandwidth/lane count registers */
    93		if (anx7688->fw_version >= ANX7688_MINIMUM_FW_VERSION)
    94			data->filter = true;
    95		else
    96			/* Warn, but not fail, for backwards compatibility */
    97			DRM_WARN("Old ANX7688 FW version (0x%04x), not filtering\n",
    98				 anx7688->fw_version);
    99	
   100		data->bridge.funcs = &anx7688_bridge_funcs;
   101		drm_bridge_add(&data->bridge);
   102	
   103		return 0;
   104	}
   105	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (33509 bytes)