linux-kernel - Re: [PATCH v2] pid: Fix error return value in some cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200308170750.jhl5rxyy4ek5tl7l@wittgenstein>
Date:   Sun, 8 Mar 2020 18:07:50 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Corey Minyard <cminyard@...sta.com>
Cc:     minyard@....org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Adrian Reber <areber@...hat.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Dmitry Safonov <0x7f454c46@...il.com>,
        Andrei Vagin <avagin@...il.com>
Subject: Re: [PATCH v2] pid: Fix error return value in some cases

On Sat, Mar 07, 2020 at 07:11:36AM -0600, Corey Minyard wrote:
> On Sat, Mar 07, 2020 at 12:00:07PM +0100, Christian Brauner wrote:
> > On Fri, Mar 06, 2020 at 11:23:14AM -0600, minyard@....org wrote:
> > > From: Corey Minyard <cminyard@...sta.com>
> > > 
> > > Recent changes to alloc_pid() allow the pid number to be specified on
> > > the command line.  If set_tid_size is set, then the code scanning the
> > > levels will hard-set retval to -EPERM, overriding it's previous -ENOMEM
> > > value.
> > > 
> > > After the code scanning the levels, there are error returns that do not
> > > set retval, assuming it is still set to -ENOMEM.
> > > 
> > > So set retval back to -ENOMEM after scanning the levels.
> > > 
> > > Fixes: 49cb2fc42ce4 "fork: extend clone3() to support setting a PID"
> > > Signed-off-by: Corey Minyard <cminyard@...sta.com>
> > > Cc: <stable@...r.kernel.org> # 5.5
> > > Cc: Adrian Reber <areber@...hat.com>
> > > Cc: Christian Brauner <christian.brauner@...ntu.com>
> > > Cc: Oleg Nesterov <oleg@...hat.com>
> > > Cc: Dmitry Safonov <0x7f454c46@...il.com>
> > > Cc: Andrei Vagin <avagin@...il.com>
> > 
> > Thanks! I've pulled the patch now and applied.

Applied as:
https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/commit/?h=fixes&id=b26ebfe12f34f372cf041c6f801fa49c3fb382c5

Should show up in -next around Monday and I'll target it for rc6. Should
then be backported to v5.5 rather soon!

Thanks!