linux-kernel - Re: [PATCH] sched/fair: fix build warning about undefined test_idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200308183448.GI3772@suse.de>
Date:   Sun, 8 Mar 2020 18:34:48 +0000
From:   Mel Gorman <mgorman@...e.de>
To:     qiwuchen55@...il.com
Cc:     mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com,
        linux-kernel@...r.kernel.org, chenqiwu <chenqiwu@...omi.com>
Subject: Re: [PATCH] sched/fair: fix build warning about undefined
 test_idle_cores()

On Sun, Mar 08, 2020 at 11:53:12PM +0800, qiwuchen55@...il.com wrote:
> From: chenqiwu <chenqiwu@...omi.com>
> 
> The build with arm64's defconfig:
> CONFIG_SCHED_MC=y
> # CONFIG_SCHED_SMT is not set
> 
> Trigger the following warning due to test_idle_cores()'s definition
> missing:
> kernel/sched/fair.c:1524:20: warning: ???test_idle_cores??? declared ???static???
> 	but never defined [-Wunused-function]
> 
> Move the CONFIG_SCHED_SMT ifdeffery around test_idle_cores()'s declaration
> to fix it.
> 
> Signed-off-by: chenqiwu <chenqiwu@...omi.com>

Thanks. A fix has been merged to tip/sched/core as

commit 76c389ab2b5e300698eab87f9d4b7916f14117ba
Author: Valentin Schneider <valentin.schneider@....com>
Date:   Tue Mar 3 11:02:57 2020 +0000

    sched/fair: Fix kernel build warning in test_idle_cores() for !SMT NUMA


-- 
Mel Gorman
SUSE Labs