linux-kernel - Re: [PATCH] cvt_fallthrough: A tool to convert /* fallthrough */ comments to fallthrough;

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a0a3e7b-9c76-22f8-8dbf-acd9960d7950@embeddedor.com>
Date:   Sun, 8 Mar 2020 14:14:48 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Joe Perches <joe@...ches.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Cc:     clang-built-linux@...glegroups.com
Subject: Re: [PATCH] cvt_fallthrough: A tool to convert /* fallthrough */
 comments to fallthrough;



On 3/8/20 03:58, Joe Perches wrote:
> On Sun, 2020-03-08 at 01:11 -0600, Gustavo A. R. Silva wrote:
>> On 3/8/20 01:02, Joe Perches wrote:
>>>> or if you are suggesting that
>>>> the maintainers will have the predisposition of applying
>>>> patches that will modify their coding style and then go and
>>>> willingly fix that. I doubt the latter, though.
>>>
>>> If any do actually use the script, I guess we'll see.
>>>
>> Yep. In the meantime is a NACK from me for this version
>> of your patch.
> 
> Generic code reformatters of comments to code are not
> particularly common.
> 

I might not be getting my point across. It's no a matter of
reformatting something. It's the opposite, it's a matter of
not messing (removing existing blank lines) with the current
format and merely focusing on replacing comments.

--
Gustavo