linux-kernel - Re: [PATCH RFC] MAINTAINERS: include GOOGLE FIRMWARE entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0738b8e5422e60cabfbf58d5d812da20128be750.camel@perches.com>
Date:   Sun, 08 Mar 2020 13:13:38 -0700
From:   Joe Perches <joe@...ches.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Julius Werner <jwerner@...omium.org>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] MAINTAINERS: include GOOGLE FIRMWARE entry

On Sun, 2020-03-08 at 20:51 +0100, Lukas Bulwahn wrote:
> All files in drivers/firmware/google/ are identified as part of THE REST
> according to MAINTAINERS, but they are really maintained by others.
> 
> Add a basic entry for drivers/firmware/google/ based on a simple statistics
> on tags of commits in that directory:
> 
>   $ git log drivers/firmware/google/ | grep '\-by:' \
>       | sort | uniq -c | sort -nr
>      62     Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>      13     Reviewed-by: Guenter Roeck <groeck@...omium.org>
>      12     Signed-off-by: Stephen Boyd <swboyd@...omium.org>
>      11     Reviewed-by: Julius Werner <jwerner@...omium.org>
> 
> There is no specific mailing list for this driver, based on observations
> on the patch emails, and the git history suggests the driver is maintained.

The sign-off list is definitely not the MAINTAINER list
as that sign-off list can identify the upstreaming path
and not the actual maintainers.

You should instead try to identify the MAINTAINERS as authors
of the various patches rather than the sign-off list.

And even then you need to isolate the trivial changes from
the actual defect correction and significant features added.

And also time-limit the range of commits as people come and
go and only relatively recent changes should be analyzed.

For instance:

$ git log --since=2-years-ago --no-merges --pretty="%aN <%aE>	%s" -- drivers/firmware/google
Gustavo A. R. Silva <gustavo@...eddedor.com>    firmware: google: vpd: Replace zero-length array with flexible-array member
Gustavo A. R. Silva <gustavo@...eddedor.com>    firmware: google: memconsole: Replace zero-length array with flexible-array member
Arthur Heymans <arthur@...ymans.xyz>    firmware: google: Probe for a GSMI handler in firmware
Arthur Heymans <arthur@...ymans.xyz>    firmware: google: Unregister driver_info on failure and exit in gsmi
Patrick Rudolph <patrick.rudolph@...ements.com> firmware: google: Release devices before unregistering the bus
Brian Norris <briannorris@...omium.org> firmware: google: increment VPD key_len properly
Hung-Te Lin <hungte@...omium.org>       firmware: google: check if size is valid when decoding VPD data
Thomas Gleixner <tglx@...utronix.de>    treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 287
Stephen Boyd <swboyd@...omium.org>      firmware: google: coreboot: Drop unnecessary headers
Stephen Boyd <swboyd@...omium.org>      firmware: google: memconsole: Drop global func pointer
Stephen Boyd <swboyd@...omium.org>      firmware: google: memconsole: Drop __iomem on memremap memory
Stephen Boyd <swboyd@...omium.org>      firmware: google: memconsole: Use devm_memremap()
Stephen Boyd <swboyd@...omium.org>      firmware: google: Add a module_coreboot_driver() macro and use it
Thomas Gleixner <tglx@...utronix.de>    treewide: Add SPDX license identifier - Makefile/Kconfig
Thomas Gleixner <tglx@...utronix.de>    treewide: Add SPDX license identifier for more missed files
Stephen Boyd <swboyd@...omium.org>      firmware: vpd: Drop __iomem usage for memremap() memory
Furquan Shaikh <furquan@...omium.org>   gsmi: Add GSMI commands to log S0ix info
Duncan Laurie <dlaurie@...omium.org>    gsmi: Remove autoselected dependency on EFI and EFI_VARS
Duncan Laurie <dlaurie@...omium.org>    gsmi: Add coreboot to list of matching BIOS vendors
Duncan Laurie <dlaurie@...omium.org>    gsmi: Fix bug in append_to_eventlog sysfs handler
Colin Ian King <colin.king@...onical.com>       firmware: vpd: fix spelling mistake "partion" -> "partition"
Stephen Boyd <swboyd@...omium.org>      firmware: coreboot: Only populate devices in coreboot_table_init()
Stephen Boyd <swboyd@...omium.org>      firmware: coreboot: Remap RAM with memremap() instead of ioremap()
Stephen Boyd <swboyd@...omium.org>      firmware: coreboot: Collapse platform drivers into bus core
Stephen Boyd <swboyd@...omium.org>      firmware: coreboot: Make bus registration symmetric
Stephen Boyd <swboyd@...omium.org>      firmware: coreboot: Unmap ioregion after device population
Stephen Boyd <swboyd@...omium.org>      firmware: coreboot: Let OF core populate platform device
Colin Ian King <colin.king@...onical.com>       firmware: google: make structure gsmi_dev static
Anton Vasilyev <vasilyev@...ras.ru>     firmware: vpd: Fix section enabled flag on vpd_section_destroy
Samuel Holland <samuel@...lland.org>    firmware: coreboot: Add coreboot framebuffer driver
Samuel Holland <samuel@...lland.org>    firmware: coreboot: Remove unused coreboot_table_find
Samuel Holland <samuel@...lland.org>    firmware: vpd: Probe via coreboot bus
Samuel Holland <samuel@...lland.org>    firmware: memconsole: Probe via coreboot bus
Samuel Holland <samuel@...lland.org>    firmware: coreboot: Expose the coreboot table as a bus

Thomas Gleixner did licensing changes treewide which
would have no maintainer role, Gustavo Silva did generic
style changes and Stephen Boyd is really the only party
here that has done fundamental changes.

It's not an easy problem, but adding