linux-kernel - Re: [PATCH] cvt_fallthrough: A tool to convert /* fallthrough */ comments to fallthrough;

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1994e1c86a97619f233ccd93d7714acda9b8cd3.camel@perches.com>
Date:   Sun, 08 Mar 2020 15:05:00 -0700
From:   Joe Perches <joe@...ches.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Cc:     clang-built-linux@...glegroups.com
Subject: Re: [PATCH] cvt_fallthrough: A tool to convert /* fallthrough */
 comments to fallthrough;

On Sun, 2020-03-08 at 17:04 -0500, Gustavo A. R. Silva wrote:
> 
> The point is: will you update your patch so it doesn't remove
> existing blank lines from the code?

No.

In the first place, I believe what I did is
the preferred style

You need to look at the code and see what you
think needs to be done and then do it instead
of merely sending a fairly pointless nak when
in fact you can't really nak it.  You could
reasonably object to it, but you aren't really
a listed maintainer of any subsystem and you
don't have an upstream tree that is being pulled
by anyone.

I believe it would not trivial to implement
your desire.  You are welcome to try.