linux-kernel - Re: [PATCH] cvt_fallthrough: A tool to convert /* fallthrough */ comments to fallthrough;

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6773b7e3-8ce4-55d1-8bb7-bde6d9f6e887@embeddedor.com>
Date:   Sun, 8 Mar 2020 00:46:23 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Joe Perches <joe@...ches.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Cc:     clang-built-linux@...glegroups.com
Subject: Re: [PATCH] cvt_fallthrough: A tool to convert /* fallthrough */
 comments to fallthrough;



On 3/7/20 21:01, Joe Perches wrote:
> On Sat, 2020-03-07 at 15:30 -0600, Gustavo A. R. Silva wrote:
>> Some people consistently add blank lines as part of their code style,
>> and if I were
>> one of those people, I wouldn't like to have such lines removed.
> 
> It's a patch generator, it's not perfect.
> Nothing is nor ever will be.

Wise words. The thing is that this is feedback over a proposed
patch.

> It's quite simple to add blank lines if that's
> what any maintainer desires.
> 

I'm not sure if you are saying that it's not a problem to
update your proposed patch, or if you are suggesting that
the maintainers will have the predisposition of applying
patches that will modify their coding style and then go and
willingly fix that. I doubt the latter, though.

--
Gustavo