linux-kernel - Re: [PATCH v4 4/5] dt-bindings: input: Add docs for ADC driven joystick.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 09 Mar 2020 22:41:00 +0100
From:   Artur Rojek <contact@...ur-rojek.eu>
To:     Rob Herring <robh@...nel.org>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Paul Cercueil <paul@...pouillou.net>,
        Heiko Stuebner <heiko@...ech.de>, linux-input@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org
Subject: Re: [PATCH v4 4/5] dt-bindings: input: Add docs for ADC driven
 joystick.

Hi Rob,

On 2020-03-09 21:38, Rob Herring wrote:
> On Sat,  7 Mar 2020 22:14:11 +0100, Artur Rojek wrote:
>> Add documentation for the adc-joystick driver, used to provide support
>> for joysticks connected over ADC.
>> 
>> Signed-off-by: Artur Rojek <contact@...ur-rojek.eu>
>> Tested-by: Paul Cercueil <paul@...pouillou.net>
>> ---
>> 
>>  Changes:
>> 
>>  v2: - Add `reg` property to axis subnode in order to enumerate the 
>> axes,
>>      - rename `linux,abs-code` property to `linux,code`,
>>      - drop `linux,` prefix from the remaining properties of axis 
>> subnode
>> 
>>  v3: no change
>> 
>>  v4: - remove "bindings" from the unique identifier string,
>>      - replace `|` with `>` for all description properties,
>>      - specify the number of items for `io-channels`,
>>      - correct the regex pattern of `axis` property,
>>      - specify the value range of `reg` property for each axis,
>>      - put `abs-range` properties under `allOf`
>> 
>>  .../bindings/input/adc-joystick.yaml          | 121 
>> ++++++++++++++++++
>>  1 file changed, 121 insertions(+)
>>  create mode 100644 
>> Documentation/devicetree/bindings/input/adc-joystick.yaml
>> 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
Like with the previous versions of this patch set, the DTS example 
requires that
patch [2/5] is applied first. When that is done, the DT check does 
succeed here.

Regards,
Artur
> 
> Error:
> Documentation/devicetree/bindings/input/adc-joystick.example.dts:22.31-32
> syntax error
> FATAL ERROR: Unable to parse input tree
> scripts/Makefile.lib:311: recipe for target
> 'Documentation/devicetree/bindings/input/adc-joystick.example.dt.yaml'
> failed
> make[1]: ***
> [Documentation/devicetree/bindings/input/adc-joystick.example.dt.yaml]
> Error 1
> Makefile:1262: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2
> 
> See https://patchwork.ozlabs.org/patch/1250951
> Please check and re-submit.