lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Mar 2020 07:13:19 +0800 From: Chun-Hung Wu <chun-hung.wu@...iatek.com> To: Ulf Hansson <ulf.hansson@...aro.org> CC: Chaotian Jing <chaotian.jing@...iatek.com>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, "Matthias Brugger" <matthias.bgg@...il.com>, Linus Walleij <linus.walleij@...aro.org>, Pavel Machek <pavel@....cz>, Kate Stewart <kstewart@...uxfoundation.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Pan Bian <bianpan2016@....com>, Thomas Gleixner <tglx@...utronix.de>, Allison Randal <allison@...utok.net>, Mathieu Malaterre <malat@...ian.org>, Stanley Chu <stanley.chu@...iatek.com>, Kuohong Wang <kuohong.wang@...iatek.com>, Android Kernel Team <kernel-team@...roid.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@...ts.infradead.org>, DTML <devicetree@...r.kernel.org>, <wsd_upstream@...iatek.com>, Linux ARM <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH v3 1/4] mmc: core: expose MMC_CAP2_CQE* to dt On Wed, 2020-03-04 at 14:04 +0100, Ulf Hansson wrote: > On Mon, 17 Feb 2020 at 07:56, Chun-Hung Wu <chun-hung.wu@...iatek.com> wrote: > > > > Expose MMC_CAP2_CQE and MMC_CAP2_CQE_DCMD > > to host->caps2 if > > 1. "supports-cqe" is defined in dt and > > 2. "disable-cqe-dcmd" is not defined in dt. > > Both of these DT properties are defined as common mmc DT properties, > so the above isn't really correct. Please clarify this. Yes, the properties is common. But I think the "supports-cqe" or "disable-cqe-dcmd" is defined in vendor's mmc dt, not common mmc dt? Don't know what's wrong with the above description, any suggestion? > > Moreover, I suggest to update commit message header into "mmc: core: > Extend mmc_of_parse() to parse CQE bindings", as I think it better > describes the change. Thanks, I think the commit message you provide is better, will change it in v4. > > > > > Signed-off-by: Chun-Hung Wu <chun-hung.wu@...iatek.com> > > --- > > drivers/mmc/core/host.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c > > index 105b7a7..efb0dbe 100644 > > --- a/drivers/mmc/core/host.c > > +++ b/drivers/mmc/core/host.c > > @@ -319,6 +319,14 @@ int mmc_of_parse(struct mmc_host *host) > > host->caps2 |= MMC_CAP2_NO_SD; > > if (device_property_read_bool(dev, "no-mmc")) > > host->caps2 |= MMC_CAP2_NO_MMC; > > + if (device_property_read_bool(dev, "supports-cqe")) > > + host->caps2 |= MMC_CAP2_CQE; > > + > > + /* Must be after "supports-cqe" check */ > > + if (!device_property_read_bool(dev, "disable-cqe-dcmd")) { > > + if (host->caps2 & MMC_CAP2_CQE) > > Does it really doesn't matter if we set this cap, even if MMC_CAP2_CQE > isn't set? You can probably skip the check above. Will remove MMC_CAP2_CQE check here. > > > + host->caps2 |= MMC_CAP2_CQE_DCMD; > > + } > > > > /* Must be after "non-removable" check */ > > if (device_property_read_u32(dev, "fixed-emmc-driver-type", &drv_type) == 0) { > > -- > > 1.9.1 > > Kind regards > Uffe
Powered by blists - more mailing lists