lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 9 Mar 2020 09:20:14 +0200 From: Adrian Hunter <adrian.hunter@...el.com> To: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>, linux-kernel@...r.kernel.org Cc: phil@...pberrypi.com, linux-mmc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, f.fainelli@...il.com, stefan.wahren@...e.com, bcm-kernel-feedback-list@...adcom.com, linux-rpi-kernel@...ts.infradead.org, Ulf Hansson <ulf.hansson@...aro.org> Subject: Re: [PATCH v2 05/11] mmc: sdhci: pxav3: Use sdhci_set_power_and_voltage() On 6/03/20 7:44 pm, Nicolas Saenz Julienne wrote: > The sdhci core provides a helper function with the same functionality as > this controller's set_power() callback. Use it instead. > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de> > --- > drivers/mmc/host/sdhci-pxav3.c | 20 +------------------- > 1 file changed, 1 insertion(+), 19 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c > index e55037ceda73..75fe90b88f9b 100644 > --- a/drivers/mmc/host/sdhci-pxav3.c > +++ b/drivers/mmc/host/sdhci-pxav3.c > @@ -297,27 +297,9 @@ static void pxav3_set_uhs_signaling(struct sdhci_host *host, unsigned int uhs) > __func__, uhs, ctrl_2); > } > > -static void pxav3_set_power(struct sdhci_host *host, unsigned char mode, > - unsigned short vdd) > -{ > - struct mmc_host *mmc = host->mmc; > - u8 pwr = host->pwr; > - > - sdhci_set_power_noreg(host, mode, vdd); > - > - if (host->pwr == pwr) > - return; > - > - if (host->pwr == 0) > - vdd = 0; > - > - if (!IS_ERR(mmc->supply.vmmc)) > - mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, vdd); > -} This code is different. The commit message should explain why it is equivalent. Has it been tested? > - > static const struct sdhci_ops pxav3_sdhci_ops = { > .set_clock = sdhci_set_clock, > - .set_power = pxav3_set_power, > + .set_power = sdhci_set_power_and_bus_voltage, > .platform_send_init_74_clocks = pxav3_gen_init_74_clocks, > .get_max_clock = sdhci_pltfm_clk_get_max_clock, > .set_bus_width = sdhci_set_bus_width, >
Powered by blists - more mailing lists