linux-kernel - Re: [PATCH] kretprobe: check re-registration of the same kretprobe earlier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d5343941-b483-679e-d0f9-09793fa51200@huawei.com>
Date:   Mon, 9 Mar 2020 15:38:29 +0800
From:   "chengjian (D)" <cj.chengjian@...wei.com>
To:     Masami Hiramatsu <mhiramat@...nel.org>
CC:     Ingo Molnar <mingo@...nel.org>, <linux-kernel@...r.kernel.org>,
        <huawei.libin@...wei.com>, <xiexiuqi@...wei.com>,
        <bobo.shaobowang@...wei.com>, <naveen.n.rao@...ux.ibm.com>,
        <anil.s.keshavamurthy@...el.com>, <davem@...emloft.net>
Subject: Re: [PATCH] kretprobe: check re-registration of the same kretprobe
 earlier


On 2020/3/7 17:54, Masami Hiramatsu wrote:
> Ah, I see. I thought that you said ri is use-after-free, but in reality,
> rp is use-after-free (use-after-init). OK.
>
>> And the problem here is destructive, it destroyed all the data of the
>> previously registered kretprobe,
>> it can lead to a system crash, memory leak, use-after-free and even some
>> other unexpected behavior.
> Yes, so I think we should do
>
> +	/* Return error if it's being re-registered */
> +	ret = check_kprobe_rereg(&rp->kp);
> +	if (WARN_ON(ret))
> +		return ret;
>
> This will give a warning message to the developer.
>
> Thank you,

OK, I will add the WARN_ON in V2.

Thank you.


----Cheng Jian