linux-kernel - Re: [PATCH] staging: greybus: Fix the irq API abuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200309083049.GA14211@localhost>
Date:   Mon, 9 Mar 2020 09:30:49 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Rui Miguel Silva <rmfrfs@...il.com>,
        Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        greybus-dev@...ts.linaro.org
Subject: Re: [PATCH] staging: greybus: Fix the irq API abuse

On Fri, Mar 06, 2020 at 02:24:13PM +0100, Thomas Gleixner wrote:
> Nothing outside of low level architecture code is supposed to look up
> interrupt descriptors and fiddle with them.
> 
> Replace the open coded abuse by calling generic_handle_irq().
> 
> This still does not explain why and in which context this connection
> magic is injecting interrupts in the first place and why this is correct
> and safe, but at least the API abuse is gone.

Yeah, there's more to that story. The interrupt-handling was known to
have issues, but I can't seem to find the details right now.

> Fixes: 036aad9d0224 ("greybus: gpio: add interrupt handling support")
> Fixes: 2611ebef8322 ("greybus: gpio: don't call irq-flow handler directly")
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

Acked-by: Johan Hovold <johan@...nel.org>

Johan