linux-kernel - RE: Re:[RFC net-next] net: phy: Add basic support for Synopsys XPCS using a PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN8PR12MB3266C896974574439AFEA0D6D3FE0@BN8PR12MB3266.namprd12.prod.outlook.com>
Date:   Mon, 9 Mar 2020 09:22:12 +0000
From:   Jose Abreu <Jose.Abreu@...opsys.com>
To:     "Chng, Jack Ping" <jack.ping.chng@...ux.intel.com>
CC:     Andrew Lunn <andrew@...n.ch>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Joao Pinto <Joao.Pinto@...opsys.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: Re:[RFC net-next] net: phy: Add basic support for Synopsys XPCS
 using a PHY driver

From: Chng, Jack Ping <jack.ping.chng@...ux.intel.com>
Date: Feb/04/2020, 09:41:35 (UTC+00:00)

> Currently our network SoC has something like this:
> XGMAC-> XPCS -> Combo PHY -> PHY
> 
> In the xpcs driver probe(), get and calibrate the phy:
> 
> priv->phy = devm_phy_get(&pdev->dev, "phy");
> if (IS_ERR(priv->phy)) {
>      dev_warn(dev, "No phy\n");
>      return PTR_ERR(priv->phy);
> }
> 
> ret = phy_init(priv->phy);
> if (ret)
>      return ret;
> 
> ret = phy_power_on(priv->phy);
> if (ret) {
>      phy_exit(priv->phy);
>      return ret;
> }
> ret = phy_calibrate(priv->phy);
> if (ret) {
>      phy_exit(priv->phy);
>      return ret;
> }
> 
> xpcs driver needs to handle phy or phy_device depending on the phy?

Apologies for the delayed answer.

I think XPCS should be agnostic of PHY so this should be handled by stmmac 
core and 





































































PHYLINK.

I submitted a new series: https://patchwork.ozlabs.org/project/netdev/list/?series=163171

Can you please test it ?

---
Thanks,
Jose Miguel Abreu