linux-kernel - Re: [PATCH v2] scsi: aacraid: fix -Wcast-function-type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a0e6373-b4a3-0822-3b65-e3b326266832@huawei.com>
Date:   Mon, 9 Mar 2020 09:23:50 +0000
From:   John Garry <john.garry@...wei.com>
To:     Phong Tran <tranmanphong@...il.com>, <aacraid@...rosemi.com>,
        <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
        <bvanassche@....org>
CC:     <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <keescook@...omium.org>
Subject: Re: [PATCH v2] scsi: aacraid: fix -Wcast-function-type

On 08/03/2020 02:01, Phong Tran wrote:
> correct usage prototype of callback scsi_cmnd.scsi_done()
> Report by: https://github.com/KSPP/linux/issues/20
> 

no harm to add:

drivers/scsi/aacraid/aachba.c:813:23: warning: cast between incompatible 
function types from ‘int (*)(struct scsi_cmnd *)’ to ‘void (*)(struct 
scsi_cmnd *)’ [-Wcast-function-type]


> Signed-off-by: Phong Tran <tranmanphong@...il.com>
> ---
>   drivers/scsi/aacraid/aachba.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
> index 33dbc051bff9..20ca3647d211 100644
> --- a/drivers/scsi/aacraid/aachba.c
> +++ b/drivers/scsi/aacraid/aachba.c
> @@ -798,6 +798,11 @@ static int aac_probe_container_callback1(struct scsi_cmnd * scsicmd)
>   	return 0;
>   }
>   
> +static void  aac_probe_container_scsi_done(struct scsi_cmnd *scsi_cmnd)

supernit: double whitespace

> +{
> +	aac_probe_container_callback1(scsi_cmnd);
> +}
> +
>   int aac_probe_container(struct aac_dev *dev, int cid)
>   {
>   	struct scsi_cmnd *scsicmd = kmalloc(sizeof(*scsicmd), GFP_KERNEL);
> @@ -810,7 +815,7 @@ int aac_probe_container(struct aac_dev *dev, int cid)
>   		return -ENOMEM;
>   	}
>   	scsicmd->list.next = NULL;
> -	scsicmd->scsi_done = (void (*)(struct scsi_cmnd*))aac_probe_container_callback1;
> +	scsicmd->scsi_done = aac_probe_container_scsi_done;
>   
>   	scsicmd->device = scsidev;
>   	scsidev->sdev_state = 0;
>