linux-kernel - Re: [PATCH RFC 0/3] clean up misc device minor numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200309095102.GA13722@haproxy.com>
Date:   Mon, 9 Mar 2020 10:51:02 +0100
From:   Willy TARREAU <wtarreau@...roxy.com>
To:     Zhenzhong Duan <zhenzhong.duan@...il.com>
Cc:     linux-kernel@...r.kernel.org, jdike@...toit.com, richard@....at,
        anton.ivanov@...bridgegreys.com, miguel.ojeda.sandonis@...il.com,
        ksenija.stanojevic@...il.com, arnd@...db.de,
        gregkh@...uxfoundation.org, mpm@...enic.com,
        herbert@...dor.apana.org.au, jonathan@...zard.org.uk,
        benh@...nel.crashing.org, davem@...emloft.net,
        b.zolnierkie@...sung.com, rjw@...ysocki.net, pavel@....cz,
        len.brown@...el.com
Subject: Re: [PATCH RFC 0/3] clean up misc device minor numbers

On Mon, Mar 09, 2020 at 10:17:44AM +0800, Zhenzhong Duan wrote:
> Some the misc device minor numbers definitions spread in different
> local c files, specially some are duplicate number with different
> name, some are same name with conflict numbers, some prefer dynamic
> minors.
> 
> This patchset try to address all of them.

Thanks for this! When I initially created panel.c about 20 years ago
I didn't even realize there was a miscdevice.h to centralize all this.
It's definitely cleaner this way.

> To be honest, I didn't try build on arm or sparc arch which some
> drivers depend on as I have little experience on cross-compile.
> But I still checked the patch carefully to ensure it builds
> in theory. Appreciate if anyone willing to test build on those arch.

So I've built for ARM to check, I could enable and successfully build
these modules that you touched: charlcd, panel, applicom, devsynth,
speakup_soft. The other ones might require less obvious configs to be
build-tested.

Willy